feat(cdk): expose cache to components #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipcrm
force-pushed
the
ipcrm/GROW-2498/cache-4-components
branch
3 times, most recently
from
773a836 to
1fb5389
Compare
ipcrm
force-pushed
the
ipcrm/GROW-2498/cache-4-components
branch
2 times, most recently
from
4640a66 to
35076ab
Compare
afiune
reviewed
Dec 14, 2023
afiune
changed the title
added 5 commits
December 14, 2023 14:11
The previous imports-check target uses `go list` to find code to scan. The problem is that `go list` produces a listing of directories to input into goimports. /a/b/c /a/b/c/d /a/b/c/e ---> example we want to exclude In the example listing above, we want to exclude `e`. That was previously done by excluding `e` via a `grep -v` command that followed `go list`. The result is that the path with `e` on the end is excluded, but `/a/b/c` is still scanned causing the excluded path to get scanned anyway. This commit swaps all this out for a find command that excludes the paths and returns filenames as input, not directories.
These can be refreshed using the make cdk-go-component-ci command, however it'll cause local integration tests to fail unless folks rebuild these manually everytime on their machines. In addition, its slowing the integration tests down substantially on an already long-running job. These resources should be fairly static so we're making the choice to include these resources statically.
ipcrm
force-pushed
the
ipcrm/GROW-2498/cache-4-components
branch
from
08ff71f to
cf85c30
Compare
afiune
approved these changes
Dec 14, 2023
| @@ -148,7 +148,7 @@ fmt-check: ## Lists formatting issues | |||
|
|
|||
| .PHONY: imports-check | |||
| imports-check: ## Lists imports issues | |||
| @test -z $(shell goimports -l $(shell go list -f {{.Dir}} ./... | grep -v proto)) | |||
| @test -z $(shell goimports -l $(shell find . -type f -name '*.go' -not -path './vendor/*' -not -path './cli/cdk/go/proto/*')) | |||
There was a problem hiding this comment.
not platform agnostic but it's fine, I don't think we run this test in CI on windows...
There was a problem hiding this comment.
Please take a look at the commit message on e043b66
It doesn't seem like go-list has a better way to solve this, but I'm open to ideas!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable CDK components to use the Lacework CLI cache.
How did you test this change?
Integration test, manually using
go-componentIssue
https://lacework.atlassian.net/browse/GROW-2498