feat: go-resty component download

[jon-stewart]

Summary

• Using go-resty
• Download progress
  • progress shown in CLI spinner
  • prototype components show progress in MB (we do not have access to total file size)
  • v1 components show process in %
  • CLI spinner updated if value changes
• No request timeout
  • can be set with environmental variable CDK_DOWNLOAD_TIMEOUT_MINUTES

How did you test this change?

Unit tests + manual

Screen.Recording.2023-12-04.at.11.25.45.mov

Issue

https://lacework.atlassian.net/browse/GROW-2596

[jvogt]

Is the 5 minute timeout a hard limit? My expectation is the download will not timeout as long as there is progress.

Example: I was on conference wifi, roughly 3mbit, and it took about 15 minutes to download the sast component manually with curl.

I would expect a sane timeout if the download does not start (something like 15 seconds), no timeout if there is progress, and maybe a longer timeout (1-5 minutes) if no data has been received.

[afiune]

The lwcomponent should not interact with STDOUT or STDERR

[jon-stewart]

How should we indicate progress?

[jon-stewart]

I am now using a virtual terminal - is this the approach you had in mind?

[jon-stewart]

@afiune Moved the code to the CLI package and showing progress in the spinner suffix

[jon-stewart]

Is the 5 minute timeout a hard limit? My expectation is the download will not timeout as long as there is progress.

Example: I was on conference wifi, roughly 3mbit, and it took about 15 minutes to download the sast component manually with curl.

I would expect a sane timeout if the download does not start (something like 15 seconds), no timeout if there is progress, and maybe a longer timeout (1-5 minutes) if no data has been received.

15 minutes! Ok yeah, we can't have a hard timeout then - unless configured with an environmental variable.

The timeouts you describe are handled by default, those are connection timeout and idle connection timeout.

[afiune]