-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.5.1 Lacework Agent Charts #60
Conversation
@@ -3,7 +3,7 @@ entries: | |||
admission-controller: | |||
- apiVersion: v2 | |||
appVersion: 0.0.1 | |||
created: "2022-05-05T22:09:37.397718-07:00" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we updated time stamps of charts that are not in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sadly, helm
doesn't have a flag to avoid updating these timestamps.
{{- if kindIs "string" .Values.laceworkConfig.serviceAccountName }} | ||
serviceAccountName: {{ .Values.laceworkConfig.serviceAccountName | quote }} | ||
{{- end}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cirego Is this documented anywhere except with respect to OpenShift?
Why isn't there a corresponding template to create a service account with this name?
By default, Lacework uses the default service account, which is something that CIS Benchmark recommends against.
However, if I specify serviceAccountName, then I need to create that service account myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @joebowbeer, great question! We have not documented this outside of Lacework as this functionality was only required for OpenShift. As for why we didn't add this functionality before? I commented in more detail on #105.
If you would like us to add a flag to auto-create the Service Account, even for agents that don't access the K8s API Server, please let us know!
No description provided.