Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated url.parse() with new URL() #1803

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

alumni
Copy link
Contributor

@alumni alumni commented Apr 25, 2024

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

Replaces the other occurrences of url.parse() with new URL(). Continuation of PR #1802.

@titanism
Copy link
Collaborator

Can you fix merge conflict @alumni ?

@titanism titanism merged commit 329cc63 into ladjs:master Apr 29, 2024
5 checks passed
@titanism
Copy link
Collaborator

@foresterre
Copy link

This is possibly a breaking change. Previously, a value like "0.0.0.0" was accepted, while it now errors with "0.0.0.0 is not a valid URL"

@gramakri
Copy link

@alumni I think this change broke IPv6 queries. See #1805 . The change makes node resolve [x]:port as a hostname instead of IPv6 address.

@alumni
Copy link
Contributor Author

alumni commented Jun 10, 2024

There's a pr open to fix it ;)

@gramakri
Copy link

@alumni ah, I was hoping you would review that PR :-D (also, there was an edit in that PR saying it's hard to test)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants