Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use itemlist component #210

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Use itemlist component #210

wants to merge 15 commits into from

Conversation

gygabor
Copy link
Collaborator

@gygabor gygabor commented Dec 29, 2021

No description provided.

@baxgas
Copy link
Collaborator

baxgas commented Dec 29, 2021

Thanks @gygabor
I have a few remarks,

  • why isn't there a Show description on the Shows listing page?
  • you use the white border hover style on the Shows and News pages, but not on Archives, shouldn't it be the same everywhere? also the number of the items per row and the title/type style should be the same, no?
  • I don't like that the white border hover sticks to the edge of the viewport (left-edge for the first, right-edge for the last in the row), there should be a bit (larger) margin around the container

@gygabor
Copy link
Collaborator Author

gygabor commented Dec 29, 2021

Thanks @gygabor I have a few remarks,

  • why isn't there a Show description on the Shows listing page?

Because the descriptions on ananasz are also missing.

  • you use the white border hover style on the Shows and News pages, but not on Archives, shouldn't it be the same everywhere? also the number of the items per row and the title/type style should be the same, no?

Because I didn't update the archive page yet.

  • I don't like that the white border hover sticks to the edge of the viewport (left-edge for the first, right-edge for the last in the row), there should be a bit (larger) margin around the container

You're right. Something happened. I'll fix it.

@baxgas
Copy link
Collaborator

baxgas commented Dec 30, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants