-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use itemlist component #210
Draft
gygabor
wants to merge
15
commits into
main
Choose a base branch
from
use-itemlist-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @gygabor
|
Because the descriptions on
Because I didn't update the archive page yet.
You're right. Something happened. I'll fix it. |
There are show descriptions, but they apear on hover, replacing the cover
image 😊 no need to make it like that in your version, just use the same
list style everywhere as we agreed
…On Wed, Dec 29, 2021, 21:00 Gábor György ***@***.***> wrote:
Thanks @gygabor <https://github.com/gygabor> I have a few remarks,
- why isn't there a Show description on the Shows listing page?
Because the descriptions on ananasz are also missing.
- you use the white border hover style on the Shows and News pages,
but not on Archives, shouldn't it be the same everywhere? also the number
of the items per row and the title/type style should be the same, no?
Because I didn't update the archive page yet.
- I don't like that the white border hover sticks to the edge of the
viewport (left-edge for the first, right-edge for the last in the row),
there should be a bit (larger) margin around the container
You're right. Something happened. I'll fix it.
—
Reply to this email directly, view it on GitHub
<#210 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIVY4E3ZTMI2K7NVI6YYID3UTNSHTANCNFSM5K56XXZA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.