feat: time handling for interest #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Teolhyn
commented
Aug 21, 2024
Teolhyn
commented
- Time (in ledger sequences) is now stored in loan manager storage
- add_interest calculates time between the present and last update to get correct amount of interest
- Added some unit tests to loan_pool
kovipu
approved these changes
Aug 21, 2024
| .storage() | ||
| .persistent() | ||
| .get(&key) | ||
| .unwrap_or(current_ledger.into_val(&e)); // If there is no previous ledger, use current. |
There was a problem hiding this comment.
Googlasin mitä eroa on unwrap_or ja unwrap_or_else välillä koska en tiennyt. Ei tässä kohtaa väliä kumpaa käyttää, mutta jos toi else-haara olisi kallista laskea, niin unwrap_or_else olisi helppo tapa optimoida.
| @@ -109,7 +112,7 @@ impl LoanPoolTrait for LoanPoolContract { | |||
| */ | |||
| let address = String::from_str( | |||
| &e, | |||
| "CCR7ARWZN4WODMEWVTRCMPPJJQKE2MBKUPJBSYWCDEOT3OLBPAPEGLPH", | |||
| "CB6MHNR6FJMQHJZDWOKAU4KESR4OARLPZ4RMN57R55P2QUBH4QJENHLY", | |||
There was a problem hiding this comment.
Tää oli kaiketi väliaikanen ratkasu?
There was a problem hiding this comment.
Joo tämä juuri pitäisi korjata 'Store loan manager’s ID for liquidity pool' tiketissä.
| let withdraw_args = vec![&e, user.to_val(), amount_2]; | ||
| let _withdraw_result: (i128, i128) = | ||
| e.invoke_contract(&contract_id, &Symbol::new(&e, "withdraw"), withdraw_args); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.