draft: fix: balance calculations and scout-audit warnings #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovipu
reviewed
Dec 15, 2024
Comment on lines
+61
to
+63
| let admin: Address = e.storage().persistent().get(&LoansDataKey::Admin).unwrap(); | ||
| admin.require_auth(); | ||
|
|
There was a problem hiding this comment.
Maybe that deploy pool test fails because the test doesn't init the manager like it should? This could probably be fixed by e.mock_all_auths() in that deploy_pool test.
kovipu
reviewed
Dec 15, 2024
| new_manager_wasm_hash: BytesN<32>, | ||
| new_pool_wasm_hash: BytesN<32>, | ||
| ) -> Result<(), Error> { | ||
| let admin: Option<Address> = e.storage().persistent().get(&LoansDataKey::Admin); |
There was a problem hiding this comment.
If we have option values in variables like this, I think we should standardize our naming so the option-wrapper variable is named opt_admin and the unwrapper data is admin
There was a problem hiding this comment.
As it's already returning Return type I'll just switch the if let Some to '?'
kovipu
reviewed
Dec 15, 2024
| pub fn upgrade(e: Env, new_wasm_hash: BytesN<32>) { | ||
| let loan_manager_addr = pool::read_loan_manager_addr(&e); | ||
| pub fn upgrade(e: Env, new_wasm_hash: BytesN<32>) -> Result<(), Error> { | ||
| let loan_manager_addr = pool::read_loan_manager_addr(&e)?; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.