Skip to content

Commit

Permalink
Split ExpressionFuzzer into ExpressionFuzzer and ExpressionFuzzerVeri…
Browse files Browse the repository at this point in the history
…fier (facebookincubator#7544)

Summary:

Before this diff, ExpressionFuzzer had a the logic of two components.
    1.  Generating a random expression.
    2.  A framework for testing correctness of expressions by generating random
        expressions and running them in different paths...etc.

This diff splits into ExpressionFuzzer and ExpressionFuzzerVerifier, ExpressionFuzzer become an independent
 component to generate random expressions.

The diff also makes ExpressionFuzzer independent on global configs, but rather uses ExpressionFuzzer::options.

Differential Revision: D51265828
  • Loading branch information
laithsakka authored and facebook-github-bot committed Nov 20, 2023
1 parent 413ce09 commit d1c0102
Show file tree
Hide file tree
Showing 8 changed files with 953 additions and 617 deletions.
3 changes: 2 additions & 1 deletion velox/expression/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ target_link_libraries(
velox_expression_verifier velox_vector_test_lib velox_vector_fuzzer
velox_type velox_expression_test_utility)

add_library(velox_expression_fuzzer ExpressionFuzzer.cpp FuzzerRunner.cpp)
add_library(velox_expression_fuzzer ExpressionFuzzer.cpp FuzzerRunner.cpp
ExpressionFuzzerVerifier.cpp)

target_link_libraries(
velox_expression_fuzzer
Expand Down
Loading

0 comments on commit d1c0102

Please sign in to comment.