wasm32-wasi: Use __errno_location instead of feature(thread_local).
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of wasi-libc provide an `__errno_location` function which returns the address of errno, similar to other platforms. Change the errno crate to use that, instead of using the unstable `feature(thread_local)`. At the moment, only Rust nightly has a new enough wasi-libc to support this, however it's not a regression because the `feature(thread_local)` already dependend on nightly. In the future, the newer wasi-libc will be in stable Rust too, making this work on stable.
|
Thanks! |
|
@sunfishcode for the record this wasi update you are referring to is that this PR? That PR will be included in 1.68.0, which is already the next release. |
|
@est31 Yes, the wasi-libc version in that PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of wasi-libc provide an
__errno_locationfunction which returns the address of errno, similar to other platforms. Change the errno crate to use that, instead of using the unstablefeature(thread_local).At the moment, only Rust nightly has a new enough wasi-libc to support this, however it's not a regression because the
feature(thread_local)already dependend on nightly. In the future, the newer wasi-libc will be in stable Rust too, making this work on stable.