Check overflow in cairo pie address calculation

[JulianGCalderon]

Check overflow in cairo pie address calculation

Description

Uses checked_add and checked_mul to return explicit errors rather than silently failing in case of an overflow.

Checklist

• Linked to Github Issue
• Unit tests added
• Integration tests added.
• This change requires new documentation.
  • Documentation has been added/updated.
  • CHANGELOG has been updated.

[github-actions]

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     27.539 s ±  0.123 s    [User: 26.822 s, System: 0.715 s]
  Range (min … max):   27.452 s … 27.626 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     27.558 s ±  0.040 s    [User: 26.822 s, System: 0.734 s]
  Range (min … max):   27.529 s … 27.586 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     15.323 s ±  0.119 s    [User: 26.842 s, System: 0.776 s]
  Range (min … max):   15.239 s … 15.406 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     15.367 s ±  0.019 s    [User: 26.885 s, System: 0.780 s]
  Range (min … max):   15.354 s … 15.380 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.00 ± 0.01 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     11.323 s ±  0.124 s    [User: 39.250 s, System: 0.872 s]
  Range (min … max):   11.236 s … 11.410 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     11.058 s ±  0.531 s    [User: 39.547 s, System: 0.909 s]
  Range (min … max):   10.682 s … 11.433 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.02 ± 0.05 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     11.080 s ±  0.082 s    [User: 39.510 s, System: 0.912 s]
  Range (min … max):   11.022 s … 11.138 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.861 s ±  0.086 s    [User: 39.340 s, System: 0.908 s]
  Range (min … max):   10.800 s … 10.922 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.02 ± 0.01 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.873 s ±  0.004 s    [User: 39.864 s, System: 0.926 s]
  Range (min … max):   10.870 s … 10.876 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.967 s ±  0.233 s    [User: 39.980 s, System: 0.888 s]
  Range (min … max):   10.802 s … 11.131 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.01 ± 0.02 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.739 s ±  0.016 s    [User: 40.263 s, System: 0.972 s]
  Range (min … max):   10.728 s … 10.750 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.793 s ±  0.134 s    [User: 40.119 s, System: 0.971 s]
  Range (min … max):   10.698 s … 10.888 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.00 ± 0.01 times faster than hyper_threading_pr threads: 16

[github-actions]

Benchmark Results for unmodified programs 🚀

Command	Mean [s]	Min [s]	Max [s]	Relative
base big_factorial	2.196 ± 0.010	2.177	2.214	1.00
head big_factorial	2.196 ± 0.019	2.174	2.238	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base big_fibonacci	2.152 ± 0.016	2.123	2.177	1.00 ± 0.01
head big_fibonacci	2.144 ± 0.008	2.128	2.152	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base blake2s_integration_benchmark	8.252 ± 0.176	7.992	8.467	1.00
head blake2s_integration_benchmark	8.339 ± 0.247	8.020	8.922	1.01 ± 0.04

Command	Mean [s]	Min [s]	Max [s]	Relative
base compare_arrays_200000	2.285 ± 0.017	2.262	2.309	1.01 ± 0.01
head compare_arrays_200000	2.271 ± 0.017	2.239	2.299	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base dict_integration_benchmark	1.480 ± 0.012	1.468	1.505	1.00
head dict_integration_benchmark	1.494 ± 0.004	1.488	1.499	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base field_arithmetic_get_square_benchmark	1.286 ± 0.017	1.261	1.316	1.00
head field_arithmetic_get_square_benchmark	1.292 ± 0.012	1.269	1.303	1.00 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base integration_builtins	8.297 ± 0.155	8.054	8.557	1.00
head integration_builtins	8.307 ± 0.162	8.017	8.464	1.00 ± 0.03

Command	Mean [s]	Min [s]	Max [s]	Relative
base keccak_integration_benchmark	8.593 ± 0.192	8.329	8.886	1.00
head keccak_integration_benchmark	8.610 ± 0.132	8.323	8.819	1.00 ± 0.03

Command	Mean [s]	Min [s]	Max [s]	Relative
base linear_search	2.274 ± 0.010	2.262	2.291	1.00 ± 0.01
head linear_search	2.269 ± 0.010	2.256	2.288	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_cmp_and_pow_integration_benchmark	1.547 ± 0.007	1.536	1.561	1.00
head math_cmp_and_pow_integration_benchmark	1.566 ± 0.007	1.558	1.584	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_integration_benchmark	1.513 ± 0.005	1.504	1.517	1.00
head math_integration_benchmark	1.519 ± 0.009	1.504	1.537	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base memory_integration_benchmark	1.252 ± 0.006	1.243	1.261	1.00 ± 0.01
head memory_integration_benchmark	1.248 ± 0.004	1.244	1.255	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base operations_with_data_structures_benchmarks	1.623 ± 0.006	1.613	1.632	1.00
head operations_with_data_structures_benchmarks	1.626 ± 0.006	1.615	1.635	1.00 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base pedersen	546.6 ± 3.8	541.6	555.6	1.00 ± 0.01
head pedersen	545.2 ± 2.2	541.2	547.5	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base poseidon_integration_benchmark	652.6 ± 8.8	643.1	674.5	1.00
head poseidon_integration_benchmark	654.6 ± 9.4	648.5	680.4	1.00 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base secp_integration_benchmark	1.897 ± 0.014	1.879	1.930	1.00
head secp_integration_benchmark	1.901 ± 0.010	1.889	1.917	1.00 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base set_integration_benchmark	623.2 ± 2.5	618.8	626.5	1.00 ± 0.01
head set_integration_benchmark	622.3 ± 2.4	619.3	627.7	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base uint256_integration_benchmark	4.536 ± 0.062	4.412	4.635	1.00
head uint256_integration_benchmark	4.540 ± 0.042	4.460	4.613	1.00 ± 0.02

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.36%. Comparing base (47ff7a9) to head (db929d7).

Files with missing lines	Patch %	Lines
vm/src/vm/runners/cairo_pie.rs	66.66%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1945      +/-   ##
==========================================
- Coverage   96.37%   96.36%   -0.01%     
==========================================
  Files         102      102              
  Lines       41245    41253       +8     
==========================================
+ Hits        39749    39754       +5     
- Misses       1496     1499       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.