Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing rule for stwo programs in make test #1962

Closed
wants to merge 1 commit into from

Conversation

FrancoGiachetta
Copy link
Contributor

@FrancoGiachetta FrancoGiachetta commented Feb 18, 2025

TITLE

Description

make test is failing because it is missing the rule for stwo programs, preventing it from compiling them before executing test and thus failing. This PR adds that rule to it.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@FrancoGiachetta FrancoGiachetta added the pipelines This PR/issue is exclusively about improving our CI label Feb 18, 2025
@FrancoGiachetta FrancoGiachetta changed the title add missing rules for stwo programs add missing rule for stwo programs in make test Feb 18, 2025
@FrancoGiachetta FrancoGiachetta marked this pull request as ready for review February 18, 2025 12:38
Copy link

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     27.616 s ±  0.343 s    [User: 26.830 s, System: 0.785 s]
  Range (min … max):   27.373 s … 27.859 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     27.507 s ±  0.391 s    [User: 26.747 s, System: 0.758 s]
  Range (min … max):   27.231 s … 27.783 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.00 ± 0.02 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     15.296 s ±  0.087 s    [User: 26.763 s, System: 0.807 s]
  Range (min … max):   15.235 s … 15.358 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     15.265 s ±  0.067 s    [User: 26.712 s, System: 0.790 s]
  Range (min … max):   15.218 s … 15.313 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.00 ± 0.01 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     11.334 s ±  0.177 s    [User: 39.606 s, System: 0.964 s]
  Range (min … max):   11.209 s … 11.459 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     11.226 s ±  0.353 s    [User: 39.504 s, System: 0.934 s]
  Range (min … max):   10.976 s … 11.475 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.01 ± 0.04 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.754 s ±  0.284 s    [User: 39.881 s, System: 0.945 s]
  Range (min … max):   10.553 s … 10.954 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.694 s ±  0.168 s    [User: 40.102 s, System: 0.969 s]
  Range (min … max):   10.575 s … 10.813 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.01 ± 0.03 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.972 s ±  0.055 s    [User: 40.269 s, System: 0.998 s]
  Range (min … max):   10.933 s … 11.011 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.763 s ±  0.007 s    [User: 40.002 s, System: 1.013 s]
  Range (min … max):   10.758 s … 10.768 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.02 ± 0.01 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.705 s ±  0.079 s    [User: 40.720 s, System: 1.088 s]
  Range (min … max):   10.649 s … 10.761 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.862 s ±  0.076 s    [User: 40.331 s, System: 1.091 s]
  Range (min … max):   10.808 s … 10.915 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.01 ± 0.01 times faster than hyper_threading_pr threads: 16


Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.230 ± 0.010 2.214 2.242 1.00 ± 0.01
head big_factorial 2.227 ± 0.023 2.191 2.262 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.164 ± 0.013 2.147 2.182 1.00
head big_fibonacci 2.175 ± 0.022 2.147 2.221 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.325 ± 0.054 8.243 8.421 1.00
head blake2s_integration_benchmark 8.341 ± 0.102 8.126 8.530 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.301 ± 0.018 2.271 2.328 1.00 ± 0.01
head compare_arrays_200000 2.296 ± 0.016 2.275 2.324 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.497 ± 0.004 1.493 1.504 1.00
head dict_integration_benchmark 1.503 ± 0.010 1.492 1.520 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.295 ± 0.012 1.273 1.311 1.00 ± 0.01
head field_arithmetic_get_square_benchmark 1.294 ± 0.011 1.281 1.317 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.363 ± 0.094 8.182 8.468 1.00
head integration_builtins 8.370 ± 0.160 8.178 8.586 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.590 ± 0.096 8.423 8.703 1.00 ± 0.02
head keccak_integration_benchmark 8.580 ± 0.119 8.402 8.742 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.287 ± 0.011 2.268 2.298 1.00
head linear_search 2.289 ± 0.016 2.257 2.310 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.577 ± 0.010 1.565 1.596 1.00 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.575 ± 0.004 1.569 1.583 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.529 ± 0.005 1.518 1.536 1.00 ± 0.01
head math_integration_benchmark 1.528 ± 0.007 1.517 1.539 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.264 ± 0.005 1.258 1.271 1.00
head memory_integration_benchmark 1.267 ± 0.004 1.261 1.275 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.641 ± 0.007 1.631 1.650 1.00 ± 0.01
head operations_with_data_structures_benchmarks 1.633 ± 0.007 1.623 1.642 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 548.6 ± 2.8 546.8 556.3 1.00
head pedersen 548.6 ± 4.0 544.9 558.9 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 649.5 ± 4.6 640.5 657.0 1.00
head poseidon_integration_benchmark 650.9 ± 6.7 642.3 666.8 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.908 ± 0.007 1.897 1.917 1.00
head secp_integration_benchmark 1.915 ± 0.010 1.900 1.933 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 639.6 ± 1.3 637.5 642.0 1.00
head set_integration_benchmark 645.6 ± 8.6 638.6 662.1 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.521 ± 0.049 4.449 4.598 1.00
head uint256_integration_benchmark 4.532 ± 0.053 4.450 4.587 1.00 ± 0.02

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (7a97bed) to head (3e10d78).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1962   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files         102      102           
  Lines       41566    41566           
=======================================
  Hits        40068    40068           
  Misses       1498     1498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YairVaknin-starkware
Copy link
Collaborator

HI @JulianGCalderon and @FrancoGiachetta
Looks like we were working on the same thing (partially).
Pls TAL here: #1963. PLS review it and let's merge it instead (contains a bit more things we need).

@FrancoGiachetta
Copy link
Contributor Author

Hi @YairVaknin-starkware! Thanks for notifying, I'll close this PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants