Added hints felt unpacking for blake. #1994
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alon-Ti
requested review from
igaray,
Oppen,
fmoletta,
juanbono,
pefontana,
gabrielbosio,
yuvalsw and
noaov1
as code owners
Alon-Ti
force-pushed
the
alont/blake-hints
branch
from
5cded45 to
91f4b82
Compare
FrancoGiachetta
requested changes
Mar 10, 2025
|
Hi there! Could you give some context of what these new hints do? |
The new blake2s opcode (see #1927 etc) requires that we split felts we would like to hash into 32-bit limbs. These are hints for cairo library code that takes an array of felts and returns an array of 32-bit limbs, with the optimization that felts under 2^63 are encoded in two limbs. |
Alon-Ti
force-pushed
the
alont/blake-hints
branch
2 times, most recently
from
218656b to
11a01ba
Compare
FrancoGiachetta
requested changes
Mar 11, 2025
Alon-Ti
force-pushed
the
alont/blake-hints
branch
from
11a01ba to
84c5eea
Compare
Alon-Ti
force-pushed
the
alont/blake-hints
branch
from
84c5eea to
ea7cf4c
Compare
FrancoGiachetta
approved these changes
Mar 13, 2025
Alon-Ti
force-pushed
the
alont/blake-hints
branch
from
ea7cf4c to
2882905
Compare
gabrielbosio
requested changes
Mar 18, 2025
vm/src/hint_processor/builtin_hint_processor/builtin_hint_processor_definition.rs
Outdated
Show resolved
Hide resolved
Alon-Ti
force-pushed
the
alont/blake-hints
branch
from
2882905 to
43d3fd4
Compare
Alon-Ti
force-pushed
the
alont/blake-hints
branch
from
43d3fd4 to
d258179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.