Skip to content

Conversation

FrancoGiachetta
Copy link
Contributor

@FrancoGiachetta FrancoGiachetta commented Sep 18, 2025

Use starknet-types-core's QM31

Description

This PR changes the implementation of a QM31 in CairoVM with starknet-types-core's one. To do so, it update starknet-types-core to 0.2.1.

Closes #2157

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

Copy link

github-actions bot commented Sep 18, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     24.688 s ±  0.085 s    [User: 23.839 s, System: 0.845 s]
  Range (min … max):   24.627 s … 24.748 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     24.844 s ±  0.047 s    [User: 24.017 s, System: 0.824 s]
  Range (min … max):   24.811 s … 24.877 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.01 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     13.424 s ±  0.011 s    [User: 23.917 s, System: 0.857 s]
  Range (min … max):   13.416 s … 13.432 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     13.482 s ±  0.088 s    [User: 24.327 s, System: 0.880 s]
  Range (min … max):   13.419 s … 13.544 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.00 ± 0.01 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):      9.870 s ±  0.027 s    [User: 37.009 s, System: 1.032 s]
  Range (min … max):    9.851 s …  9.889 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.677 s ±  0.020 s    [User: 36.448 s, System: 1.051 s]
  Range (min … max):   10.663 s … 10.691 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.08 ± 0.00 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.217 s ±  0.207 s    [User: 36.742 s, System: 1.052 s]
  Range (min … max):   10.071 s … 10.364 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.332 s ±  0.380 s    [User: 37.111 s, System: 1.047 s]
  Range (min … max):   10.063 s … 10.600 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.01 ± 0.04 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.047 s ±  0.073 s    [User: 36.866 s, System: 1.057 s]
  Range (min … max):    9.996 s … 10.099 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.120 s ±  0.109 s    [User: 37.055 s, System: 1.079 s]
  Range (min … max):   10.042 s … 10.197 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.01 ± 0.01 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.041 s ±  0.301 s    [User: 37.231 s, System: 1.147 s]
  Range (min … max):    9.829 s … 10.254 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.122 s ±  0.212 s    [User: 37.282 s, System: 1.153 s]
  Range (min … max):    9.973 s … 10.272 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.01 ± 0.04 times faster than hyper_threading_pr threads: 16


Copy link

github-actions bot commented Sep 18, 2025

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.121 ± 0.015 2.099 2.143 1.00
head big_factorial 2.133 ± 0.054 2.084 2.270 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.048 ± 0.026 2.014 2.084 1.00
head big_fibonacci 2.048 ± 0.023 2.024 2.086 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.269 ± 0.090 7.111 7.390 1.00
head blake2s_integration_benchmark 7.358 ± 0.108 7.241 7.499 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.182 ± 0.024 2.161 2.238 1.00
head compare_arrays_200000 2.184 ± 0.016 2.166 2.215 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.446 ± 0.008 1.434 1.461 1.00 ± 0.01
head dict_integration_benchmark 1.444 ± 0.012 1.425 1.464 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.199 ± 0.010 1.184 1.214 1.00
head field_arithmetic_get_square_benchmark 1.216 ± 0.020 1.193 1.253 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.449 ± 0.174 7.244 7.859 1.00
head integration_builtins 7.499 ± 0.138 7.273 7.682 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.460 ± 0.145 7.237 7.689 1.00
head keccak_integration_benchmark 7.499 ± 0.120 7.280 7.682 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.153 ± 0.018 2.126 2.181 1.00 ± 0.01
head linear_search 2.147 ± 0.021 2.113 2.176 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.506 ± 0.006 1.499 1.515 1.00
head math_cmp_and_pow_integration_benchmark 1.508 ± 0.013 1.495 1.530 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.451 ± 0.010 1.437 1.464 1.00
head math_integration_benchmark 1.458 ± 0.027 1.432 1.519 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.210 ± 0.010 1.193 1.224 1.00
head memory_integration_benchmark 1.214 ± 0.008 1.203 1.227 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.528 ± 0.008 1.515 1.543 1.00 ± 0.01
head operations_with_data_structures_benchmarks 1.528 ± 0.010 1.514 1.544 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 528.6 ± 4.5 524.8 540.2 1.00
head pedersen 689.2 ± 3.4 685.5 695.1 1.30 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 618.7 ± 2.4 616.1 623.6 1.00 ± 0.00
head poseidon_integration_benchmark 618.1 ± 1.6 615.8 621.1 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.772 ± 0.014 1.758 1.796 1.00
head secp_integration_benchmark 1.788 ± 0.025 1.764 1.830 1.01 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 649.6 ± 5.4 644.1 663.3 1.03 ± 0.01
head set_integration_benchmark 629.3 ± 2.2 626.0 633.2 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.145 ± 0.048 4.083 4.236 1.00
head uint256_integration_benchmark 4.213 ± 0.059 4.142 4.324 1.02 ± 0.02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move QM31 logic to types-rs repo
1 participant