Skip to content

Conversation

DiegoCivi
Copy link
Contributor

@DiegoCivi DiegoCivi commented Sep 29, 2025

Unify deps makefile target

Description

Tested this on mac and linux by doing make deps and then make tests. It worked on both.

Closes #2097

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

Copy link

github-actions bot commented Sep 29, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     24.426 s ±  0.010 s    [User: 23.782 s, System: 0.641 s]
  Range (min … max):   24.419 s … 24.433 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     24.562 s ±  0.053 s    [User: 23.923 s, System: 0.635 s]
  Range (min … max):   24.525 s … 24.600 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.01 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     13.322 s ±  0.012 s    [User: 24.027 s, System: 0.647 s]
  Range (min … max):   13.314 s … 13.331 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     13.291 s ±  0.001 s    [User: 24.015 s, System: 0.613 s]
  Range (min … max):   13.290 s … 13.291 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.505 s ±  0.048 s    [User: 36.360 s, System: 0.738 s]
  Range (min … max):   10.471 s … 10.539 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.229 s ±  0.073 s    [User: 36.297 s, System: 0.706 s]
  Range (min … max):   10.178 s … 10.281 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.03 ± 0.01 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.198 s ±  0.182 s    [User: 36.477 s, System: 0.740 s]
  Range (min … max):   10.069 s … 10.326 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):      9.935 s ±  0.020 s    [User: 36.699 s, System: 0.745 s]
  Range (min … max):    9.920 s …  9.949 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.03 ± 0.02 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):      9.883 s ±  0.218 s    [User: 37.223 s, System: 0.775 s]
  Range (min … max):    9.729 s … 10.038 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):      9.997 s ±  0.066 s    [User: 37.175 s, System: 0.779 s]
  Range (min … max):    9.951 s … 10.044 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.01 ± 0.02 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):      9.955 s ±  0.038 s    [User: 37.244 s, System: 0.854 s]
  Range (min … max):    9.928 s …  9.982 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.044 s ±  0.281 s    [User: 37.301 s, System: 0.819 s]
  Range (min … max):    9.846 s … 10.243 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.01 ± 0.03 times faster than hyper_threading_pr threads: 16


Copy link

github-actions bot commented Sep 29, 2025

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.012 ± 0.034 1.969 2.072 1.01 ± 0.02
head big_factorial 1.992 ± 0.024 1.963 2.042 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 1.908 ± 0.018 1.887 1.945 1.00
head big_fibonacci 1.923 ± 0.025 1.895 1.980 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 6.916 ± 0.132 6.749 7.220 1.00 ± 0.02
head blake2s_integration_benchmark 6.897 ± 0.091 6.750 7.031 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.034 ± 0.021 2.014 2.086 1.00
head compare_arrays_200000 2.043 ± 0.015 2.016 2.062 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.345 ± 0.005 1.335 1.352 1.00
head dict_integration_benchmark 1.364 ± 0.011 1.350 1.387 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.159 ± 0.012 1.143 1.178 1.00 ± 0.01
head field_arithmetic_get_square_benchmark 1.156 ± 0.012 1.142 1.173 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 6.979 ± 0.098 6.846 7.118 1.00
head integration_builtins 6.987 ± 0.090 6.857 7.096 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.150 ± 0.082 6.961 7.249 1.00 ± 0.02
head keccak_integration_benchmark 7.150 ± 0.074 6.962 7.199 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.037 ± 0.012 2.016 2.054 1.00 ± 0.01
head linear_search 2.027 ± 0.025 1.998 2.069 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.407 ± 0.006 1.400 1.423 1.00
head math_cmp_and_pow_integration_benchmark 1.414 ± 0.013 1.396 1.428 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.382 ± 0.016 1.359 1.412 1.00
head math_integration_benchmark 1.388 ± 0.018 1.364 1.430 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.142 ± 0.013 1.122 1.159 1.00
head memory_integration_benchmark 1.143 ± 0.014 1.129 1.180 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.441 ± 0.004 1.433 1.448 1.00
head operations_with_data_structures_benchmarks 1.457 ± 0.010 1.442 1.481 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 513.6 ± 2.3 510.9 517.9 1.00 ± 0.01
head pedersen 512.5 ± 2.8 507.9 516.4 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 585.6 ± 10.8 578.1 615.4 1.01 ± 0.02
head poseidon_integration_benchmark 582.7 ± 4.6 577.2 590.8 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.708 ± 0.013 1.695 1.736 1.00
head secp_integration_benchmark 1.716 ± 0.013 1.703 1.746 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 629.7 ± 5.7 624.1 642.2 1.00
head set_integration_benchmark 631.5 ± 7.0 624.0 643.1 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 3.917 ± 0.028 3.868 3.945 1.00
head uint256_integration_benchmark 3.936 ± 0.071 3.875 4.112 1.00 ± 0.02

Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.69%. Comparing base (2f8c8a0) to head (4f0b767).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2211   +/-   ##
=======================================
  Coverage   96.69%   96.69%           
=======================================
  Files         104      104           
  Lines       44023    44023           
=======================================
  Hits        42567    42567           
  Misses       1456     1456           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DiegoCivi DiegoCivi marked this pull request as ready for review September 30, 2025 15:37
Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@gabrielbosio gabrielbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I would also remove the make deps-macos mention in the README

@gabrielbosio gabrielbosio added this pull request to the merge queue Oct 17, 2025
Merged via the queue into main with commit 7b32c3e Oct 17, 2025
93 of 94 checks passed
@gabrielbosio gabrielbosio deleted the unify-deps branch October 17, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify deps make command so that it does not depend on OS

4 participants