Skip to content

Conversation

@FrancoGiachetta
Copy link
Contributor

@FrancoGiachetta FrancoGiachetta commented Oct 15, 2025

[2.x.y] Avoid generic-array version >0.14.7

Description

The same as PR #2227 but for cairo vm 2.x.y

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@FrancoGiachetta FrancoGiachetta marked this pull request as ready for review October 15, 2025 16:00
@gabrielbosio gabrielbosio changed the title Pin generic array version for 2.x.y Avoid generic-array version >0.14.7 2.x.y Oct 15, 2025
@gabrielbosio gabrielbosio changed the title Avoid generic-array version >0.14.7 2.x.y [2.x.y] Avoid generic-array version >0.14.7 Oct 15, 2025
Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.129 ± 0.037 2.095 2.225 1.01 ± 0.02
head big_factorial 2.110 ± 0.027 2.086 2.180 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.036 ± 0.021 2.018 2.084 1.00
head big_fibonacci 2.045 ± 0.026 2.019 2.113 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.637 ± 0.046 7.576 7.740 1.00 ± 0.02
head blake2s_integration_benchmark 7.629 ± 0.112 7.529 7.926 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.158 ± 0.026 2.134 2.224 1.01 ± 0.01
head compare_arrays_200000 2.146 ± 0.012 2.131 2.176 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.413 ± 0.012 1.402 1.443 1.00
head dict_integration_benchmark 1.424 ± 0.007 1.411 1.438 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.225 ± 0.022 1.208 1.266 1.01 ± 0.02
head field_arithmetic_get_square_benchmark 1.214 ± 0.009 1.205 1.234 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.723 ± 0.025 7.693 7.757 1.00
head integration_builtins 7.771 ± 0.048 7.701 7.852 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.914 ± 0.080 7.852 8.133 1.00 ± 0.01
head keccak_integration_benchmark 7.885 ± 0.023 7.831 7.910 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.146 ± 0.017 2.129 2.179 1.00
head linear_search 2.161 ± 0.023 2.139 2.206 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.500 ± 0.009 1.488 1.514 1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.488 ± 0.008 1.473 1.499 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.460 ± 0.014 1.445 1.494 1.01 ± 0.01
head math_integration_benchmark 1.449 ± 0.004 1.444 1.456 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.208 ± 0.018 1.191 1.252 1.00 ± 0.02
head memory_integration_benchmark 1.206 ± 0.017 1.190 1.253 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.565 ± 0.029 1.550 1.646 1.00 ± 0.02
head operations_with_data_structures_benchmarks 1.560 ± 0.003 1.556 1.567 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 526.9 ± 1.4 524.3 528.4 1.00 ± 0.00
head pedersen 524.7 ± 0.7 523.6 525.6 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 624.9 ± 4.8 616.3 633.1 1.00 ± 0.01
head poseidon_integration_benchmark 624.4 ± 2.5 618.7 626.9 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.851 ± 0.041 1.827 1.948 1.01 ± 0.02
head secp_integration_benchmark 1.833 ± 0.006 1.823 1.842 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 626.0 ± 1.8 623.7 630.4 1.00 ± 0.00
head set_integration_benchmark 625.7 ± 2.4 621.6 631.0 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.199 ± 0.016 4.174 4.224 1.00 ± 0.01
head uint256_integration_benchmark 4.198 ± 0.015 4.173 4.217 1.00

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.66%. Comparing base (065c8f4) to head (655deb5).
⚠️ Report is 1 commits behind head on 2.x.y.

Additional details and impacted files
@@           Coverage Diff           @@
##            2.x.y    #2230   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files         103      103           
  Lines       43646    43646           
=======================================
  Hits        42191    42191           
  Misses       1455     1455           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gabrielbosio gabrielbosio added this pull request to the merge queue Oct 17, 2025
Merged via the queue into 2.x.y with commit b9aab00 Oct 17, 2025
92 checks passed
@gabrielbosio gabrielbosio deleted the pin-generic-array-version-2.x.y branch October 17, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants