fix(vrf): use div_mod_unsigned and remove unwrap_or_default #2262
+8
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change replaces BigInt roundtrips and unwrap_or_default() calls in modular inverse helpers with a BigUint-only path using div_mod_unsigned, aligning with the project’s error-handling policy and avoiding silent failure modes. The previous unwrap_or_default() masked potential conversion issues and diverged from established patterns where conversions either cannot fail or are explicitly propagated via typed errors. The refactor also reduces unnecessary allocations by avoiding BigUint→BigInt→BigUint conversions and brings the 256-bit and 384-bit implementations in line with the 512-bit variant’s style.