Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scarb-native-test #615

Merged
merged 8 commits into from
Jun 3, 2024
Merged

Conversation

greged93
Copy link
Collaborator

Partially solves #599

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@greged93 greged93 changed the title feat: scarb test feat: scarb-native-test May 21, 2024
@greged93 greged93 marked this pull request as draft May 21, 2024 14:11
@greged93 greged93 marked this pull request as ready for review May 22, 2024 07:08
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.50000% with 199 lines in your changes are missing coverage. Please review.

Project coverage is 91.37%. Comparing base (511faf7) to head (73e6aa7).

Files Patch % Lines
src/bin/utils/test.rs 89.25% 124 Missing ⚠️
src/bin/scarb-native-test.rs 0.00% 55 Missing ⚠️
src/bin/utils/mod.rs 95.44% 17 Missing ⚠️
src/bin/cairo-native-test.rs 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   91.38%   91.37%   -0.01%     
==========================================
  Files         109      112       +3     
  Lines       35889    35952      +63     
==========================================
+ Hits        32797    32852      +55     
- Misses       3092     3100       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l added the review-ready A PR that is ready for review label May 22, 2024
azteca1998
azteca1998 previously approved these changes May 30, 2024
Copy link
Member

@edg-l edg-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this work!

@juanbono juanbono added this pull request to the merge queue Jun 3, 2024
Merged via the queue into lambdaclass:main with commit 1e850c9 Jun 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants