Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more chain reader coverage #6

Open
wants to merge 26 commits into
base: feat/add-reader-test-coverage
Choose a base branch
from

Conversation

maximopalopoli
Copy link

What Changed?

This PR adds more tests that increases the test coverage of chainio/clients/elcontracts/reader_test.go. Note: To execute some tests you may need to remake the bindings to use MockERC20 binding (run make bindings).

The functions now covered are:

  • GetAllocatableMagnitude
  • GetMaxMagnitudes
  • GetOperatorShares
  • GetOperatorsShares

Note: This branch has been created based on the previous branch, so should be merged after it

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

maximopalopoli and others added 26 commits January 14, 2025 11:25
Co-authored-by: Pablo Deymonnaz <[email protected]>
Co-authored-by: Tomás Grüner <[email protected]>
Co-authored-by: ricomateo <[email protected]>
Co-authored-by: Tomás Grüner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants