forked from Layr-Labs/eigensdk-go
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add more chain reader coverage #6
Open
maximopalopoli
wants to merge
26
commits into
feat/add-reader-test-coverage
Choose a base branch
from
test/add-more-chain-reader-coverage
base: feat/add-reader-test-coverage
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test: add more chain reader coverage #6
maximopalopoli
wants to merge
26
commits into
feat/add-reader-test-coverage
from
test/add-more-chain-reader-coverage
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tomasarrachea <[email protected]> Co-authored-by: Tomás Grüner <[email protected]>
Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: Tomás Grüner <[email protected]>
…#436) Co-authored-by: Tomás Grüner <[email protected]>
Co-authored-by: Tomás Grüner <[email protected]>
Co-authored-by: ricomateo <[email protected]> Co-authored-by: Tomás Grüner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
This PR adds more tests that increases the test coverage of
chainio/clients/elcontracts/reader_test.go
. Note: To execute some tests you may need to remake the bindings to use MockERC20 binding (runmake bindings
).The functions now covered are:
Note: This branch has been created based on the previous branch, so should be merged after it
Reviewer Checklist