System contracts CI

Remove asserts from bootloader #49

Sign in to view logs

Triggered via pull request August 20, 2024 14:17

synchronize #26

evm-integration-tests-new

Status Failure

Total duration 55s

Artifacts –

system-contracts-ci.yaml

on: pull_request

test-bootloader

Annotations

11 errors and 4 warnings

Process completed with exit code 1.

lint: l1-contracts/contracts/governance/ChainAdmin.sol#L26

Error message for require is too long: 40 counted / 32 allowed

lint: l1-contracts/contracts/governance/ChainAdmin.sol#L26

GC: Use Custom Errors instead of require statements

lint: l1-contracts/contracts/governance/ChainAdmin.sol#L53

GC: Use Custom Errors instead of require statements

lint: l1-contracts/contracts/governance/ChainAdmin.sol#L54

GC: Found [ .length ] property in Loop condition. Suggestion: assign it to a variable

lint: l1-contracts/contracts/governance/ChainAdmin.sol#L72

Error message for require is too long: 55 counted / 32 allowed

lint: l1-contracts/contracts/governance/ChainAdmin.sol#L72

GC: Use Custom Errors instead of require statements

lint: l1-contracts/deploy-scripts/DecentralizeGovernanceUpgradeScript.s.sol#L20

Provide an error message for require

lint: l1-contracts/deploy-scripts/DecentralizeGovernanceUpgradeScript.s.sol#L20

GC: Use Custom Errors instead of require statements

lint: l1-contracts/deploy-scripts/DecentralizeGovernanceUpgradeScript.s.sol#L21

Provide an error message for require

lint: l1-contracts/deploy-scripts/DecentralizeGovernanceUpgradeScript.s.sol#L21

GC: Use Custom Errors instead of require statements

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

lint: l2-contracts/contracts/SystemContractsCaller.sol#L3

Found more than One contract per file. 2 contracts found!

lint: system-contracts/contracts/ContractDeployer.sol#L192

Avoid to use tx.origin