Zk server compatibility #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes decommit opcode, which was not account for if the code had already been decommitted
Adds mandated gass, handles decommit cost err, and fixes the params of mimic call
* Add vm statistics * Add tracking of precompiles cycles * Add storage and decommit cycles * Make opcode variant pub * Add cycles counter * Update zksync-era submodule * Address clippy warnings * Update era-compiler-tester submodule * Update zksync-era submodule * Fix initial value read in storage_changes * Expose opcode variants * Update zksync-era submodule * Address review comments
This was referenced Sep 3, 2024
|
Ergs comparison results: |
fkrause98
approved these changes
Sep 3, 2024
src/op_handlers/log.rs
Outdated
| @@ -82,6 +84,10 @@ pub fn add_l2_to_l1_message( | |||
| ) -> Result<(), EraVmError> { | |||
| let key = vm_state.get_register(opcode.src0_index).value; | |||
| let value = vm_state.get_register(opcode.src1_index).value; | |||
| println!( | |||
| "L1 TO L2 regusters indexes {} {}", | |||
Oppen
reviewed
Sep 4, 2024
src/execution.rs
Outdated
Comment on lines
512
to
514
| if addr >= self.heap.len() as u32 { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
This can be done out of the loop, like this:
let start = pointer.start + offset;
let end = self.heap.len().min(start + 32);
for i in start..end {
result |= U256::from(self.heap[addr as usize]) << (1 * 8);
}
resultOr quite possibly as a slice copy, if the U256 provides a byte representation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the neccessary changes on era vm to be compatible with zksync-era
Related to:
lambdaclass/zksync-era#253
lambdaclass/era-compiler-tester#24