-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieve list of nodes via DNS #63
Open
gabrielbosio
wants to merge
13
commits into
main
Choose a base branch
from
11-retrieve-list-of-nodes-via-dns
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add elixir-dns dependency. The function returns the data as it is, we still need to make the function return the URL that geth will use. I suppose that we can make that URL using the data that the DNS returns.
Add search so that it returns all the nodes from a network. Mainnet is taking too long. I will try to refactor the module to make it a bit faster. For example, by removing the list concatenation at line 64.
Refactor ETS lookup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue: #11
Based on https://eips.ethereum.org/EIPS/eip-1459#client-protocol
It returns the node records for a specific network, without verifying them.
Known issue: Sometimes, when calling
EthClient.NodesList.update_using_dns <testnet>
it throwsTo check if all the connections are used, the
DNS
library should throw an exception andNodesList.DNS
should catch it. But, in this case, it seems that an external librarySocket
is breaking.Usage