chore(l1): reduce unnecessary docker builds and remove duplicate work…

…flow executions in main (#1032)

**Motivation**

We are re-building our docker image across the jobs/workflows multiple
times, the idea is to remove as much of the duplicate executions as
possible. At the same time, while merging to main we run duplicated
jobs, the idea is to remove that duplication.

**Description**

This PR accomplish a couple of things:
- It creates a new make tasks for running hive without depending on the
image build
- It generates a new job in the hive workflow to build the image once
and then share it with every simulation
- Merges the assertoor stability check with hive to leverage the docker
image already built
- Fix an issue were workflows were triggered two times in a row while
merging to main (both `merge_group` and `push` rules were set)

Resolves #1008
Resolves #1041

.github/workflows/ci.yaml

@@ -1,8 +1,6 @@
 name: CI
 on:
   merge_group:
-  push:
-    branches: [main]
   pull_request:
     branches: ["**"]
     paths-ignore:

.github/workflows/hive_and_assertoor.yaml

@@ -0,0 +1,124 @@
+name: "Hive & Assertoor"
+on:
+  merge_group:
+    paths-ignore:
+      - "crates/l2/**"
+      - 'README.md'
+      - 'LICENSE'
+      - "**/README.md"
+      - "**/docs/**"
+  pull_request:
+    branches: ["**"]
+    paths-ignore: 
+      - "crates/l2/**"
+      - 'README.md'
+      - 'LICENSE'
+      - "**/README.md"
+      - "**/docs/**"
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
+env:
+  RUST_VERSION: 1.80.1
+
+jobs:
+  docker-build:
+    name: Docker Build image
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
+
+      - name: Build Docker image
+        uses: docker/build-push-action@v5
+        with:
+          context: .
+          file: ./Dockerfile
+          load: true
+          tags: ethereum_rust
+          outputs: type=docker,dest=/tmp/ethereum_rust_image.tar
+
+      - name: Upload artifacts
+        uses: actions/upload-artifact@v4
+        with:
+          name: ethereum_rust_image
+          path: /tmp/ethereum_rust_image.tar
+
+  run-hive:
+    name: Hive - ${{ matrix.name }}
+    needs: [docker-build]
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        include:
+          - simulation: rpc-compat
+            name: "Rpc Compat tests"
+            run_command: make run-hive-on-latest SIMULATION=ethereum/rpc-compat TEST_PATTERN="/eth_chainId|eth_getTransactionByBlockHashAndIndex|eth_getTransactionByBlockNumberAndIndex|eth_getCode|eth_getStorageAt|eth_call|eth_getTransactionByHash|eth_getBlockByHash|eth_getBlockByNumber|eth_createAccessList|eth_getBlockTransactionCountByNumber|eth_getBlockTransactionCountByHash|eth_getBlockReceipts|eth_getTransactionReceipt|eth_blobGasPrice|eth_blockNumber|ethGetTransactionCount|debug_getRawHeader|debug_getRawBlock|debug_getRawTransaction|debug_getRawReceipts|eth_estimateGas|eth_getBalance|eth_sendRawTransaction|eth_getProof|eth_getLogs"
+          - simulation: rpc-auth
+            name: "Rpc Auth tests"
+            run_command: make run-hive-on-latest SIMULATION=ethereum/rpc-compat TEST_PATTERN="/engine-auth"
+          - simulation: discv4
+            name: "Devp2p discv4 tests"
+            run_command: make run-hive-on-latest SIMULATION=devp2p TEST_PATTERN="discv4"
+          - simulation: snap
+            name: "Devp2p snap tests"
+            run_command: make run-hive-on-latest SIMULATION=devp2p TEST_PATTERN="/AccountRange"
+          - simulation: engine
+            name: "Engine tests"
+            run_command:  make run-hive-on-latest SIMULATION=ethereum/engine TEST_PATTERN="/Blob Transactions On Block 1, Cancun Genesis|Blob Transactions On Block 1, Shanghai Genesis|Blob Transaction Ordering, Single Account, Single Blob|Blob Transaction Ordering, Single Account, Dual Blob|Blob Transaction Ordering, Multiple Accounts|Replace Blob Transactions|Parallel Blob Transactions|ForkchoiceUpdatedV3 Modifies Payload ID on Different Beacon Root|NewPayloadV3 After Cancun|NewPayloadV3 Versioned Hashes|ForkchoiceUpdated Version on Payload Request"
+          - simulation: engine-cancun
+            name: "Cancun Engine tests"
+            run_command:  make run-hive-on-latest SIMULATION=ethereum/engine TEST_PATTERN="cancun/Unique Payload ID|ParentHash equals BlockHash on NewPayload|Re-Execute Payload|Payload Build after New Invalid Payload|RPC|Build Payload with Invalid ChainID|Invalid PayloadAttributes, Zero timestamp, Syncing=False|Invalid PayloadAttributes, Parent timestamp, Syncing=False|Invalid PayloadAttributes, Missing BeaconRoot, Syncing=False|Suggested Fee Recipient Test|PrevRandao Opcode Transactions Test|Invalid Missing Ancestor ReOrg, StateRoot"
+    steps:
+      - name: Download artifacts
+        uses: actions/download-artifact@v4
+        with:
+          name: ethereum_rust_image
+          path: /tmp
+
+      - name: Load image
+        run: |
+          docker load --input /tmp/ethereum_rust_image.tar
+
+      - name: Checkout sources
+        uses: actions/checkout@v3
+
+      - name: Rustup toolchain install
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: ${{ env.RUST_VERSION }}
+
+      - name: Setup Go
+        uses: actions/setup-go@v3
+
+      - name: Run Hive Simulation
+        run: ${{ matrix.run_command }}
+
+  run-assertoor:
+    name: Assertoor - Stability Check
+    runs-on: ubuntu-latest
+    needs: [docker-build]
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Download artifacts
+        uses: actions/download-artifact@v4
+        with:
+          name: ethereum_rust_image
+          path: /tmp
+
+      - name: Load image
+        run: |
+          docker load --input /tmp/ethereum_rust_image.tar      
+
+      - name: Setup kurtosis testnet and run assertoor tests
+        uses: ethpandaops/kurtosis-assertoor-github-action@v1
+        with:
+          kurtosis_version: '1.3.1'
+          ethereum_package_url: 'github.com/lambdaclass/ethereum-package'
+          ethereum_package_branch: 'ethereum-rust-integration'
+          ethereum_package_args: './test_data/network_params.yaml'

.github/workflows/levm_bench.yaml

@@ -2,10 +2,8 @@ name: LEVM benchmarks
 
 on:
   merge_group:
-  push:
     paths:
       - 'crates/vm/levm/**'
-    branches: [ main ]
   pull_request:
     paths:
       - 'crates/vm/levm/**'

Makefile

@@ -97,6 +97,9 @@ TEST_PATTERN ?= /
 run-hive: build-image setup-hive ## 🧪 Run Hive testing suite
 	cd hive && ./hive --sim $(SIMULATION) --client ethereumrust --sim.limit "$(TEST_PATTERN)"
 
+run-hive-on-latest: setup-hive ## 🧪 Run Hive testing suite with the latest docker image
+	cd hive && ./hive --sim $(SIMULATION) --client ethereumrust --sim.limit "$(TEST_PATTERN)"
+
 run-hive-debug: build-image setup-hive ## 🐞 Run Hive testing suite in debug mode
 	cd hive && ./hive --sim $(SIMULATION) --client ethereumrust --sim.limit "$(TEST_PATTERN)" --docker.output