Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(l1): reduce unnecessary docker builds and remove duplicate workflow executions in main #1032

Merged
merged 22 commits into from
Oct 31, 2024
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
489253d
Inter workflow artifact download test
rodrigo-o Oct 31, 2024
a04c8a4
Renamed the workflow correctly
rodrigo-o Oct 31, 2024
cea1fc0
moving the docker image download to hive
rodrigo-o Oct 31, 2024
5eac784
Correctly format the download job
rodrigo-o Oct 31, 2024
bb41063
Make hive depend on docker image upload
rodrigo-o Oct 31, 2024
d846f08
Checking adding steps to the job pointing to the toher workflow
rodrigo-o Oct 31, 2024
264430c
Fixed a typo
rodrigo-o Oct 31, 2024
32addef
Test workflow_run as dependency
rodrigo-o Oct 31, 2024
943bc63
Removed all call to the other workflow from hive
rodrigo-o Oct 31, 2024
e2b5126
Moving to just depending on the docker build job
rodrigo-o Oct 31, 2024
6a4b5ef
Check readding branches and making the name shorter and without spaces
rodrigo-o Oct 31, 2024
851bb80
Testing removing also concurrency and just letting the on workflow_run
rodrigo-o Oct 31, 2024
f3cab3c
defaulted to share the docker image in the same job due to the workfl…
rodrigo-o Oct 31, 2024
9d9c0dd
Moved assertoor to the same workflow as hive to share the docker image
rodrigo-o Oct 31, 2024
731eb1e
Correctly add needs
rodrigo-o Oct 31, 2024
08d2749
Check that now the workflows run
rodrigo-o Oct 31, 2024
8d75341
Merge branch 'main' into reuse-docker-build-on-other-jobs
rodrigo-o Oct 31, 2024
0e1bc33
Added checkout to the assertoor job
rodrigo-o Oct 31, 2024
60e3fd1
Remove Docker build from the hive steps
rodrigo-o Oct 31, 2024
99974cd
Reverted CI changes
rodrigo-o Oct 31, 2024
ccb4104
Resolve the duplication upon merging in main related to push + merge_…
rodrigo-o Oct 31, 2024
84eb616
Fixed a typo
rodrigo-o Oct 31, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check that now the workflows run
rodrigo-o committed Oct 31, 2024
commit 08d2749cd957456835e697b92df70ec6e5f496c1
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ on:
push:
branches: [main]
pull_request:
branches: ["**"]
branches: ["*"]
paths-ignore:
- "README.md"
- "LICENSE"
9 changes: 6 additions & 3 deletions .github/workflows/hive_and_assertoor.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "Hive & Assertoor"
name: "Hive and Assertoor"
on:
merge_group:
push:
@@ -25,16 +25,19 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Build Docker image
uses: docker/build-push-action@v5
with:
context: .
file: ./Dockerfile
load: true
load: true
tags: ethereum_rust
outputs: type=docker,dest=/tmp/ethereum_rust_image.tar

- name: Upload artifacts
uses: actions/upload-artifact@v4
with:
@@ -94,7 +97,7 @@ jobs:
- name: Run Hive Simulation
run: ${{ matrix.run_command }}

assertoor-run:
assertoor-run:
name: Assertoor - Stability Check
runs-on: ubuntu-latest
needs: [docker-build]