fix(l1, l2, levm) #1433
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -124,6 +124,10 @@ jobs: | |
| restore-keys: | | ||
| loc-report- | ||
|
|
||
| - name: Check previous loc report | ||
| run: | | ||
| cat loc_report.json | ||
|
|
||
| - name: Rename cached loc_report.json to loc_report.json.old | ||
| if: steps.cache-loc-report.outputs.cache-hit == 'true' | ||
| run: mv loc_report.json loc_report.json.old | ||
|
|
@@ -141,7 +145,7 @@ jobs: | |
|
|
||
| - name: Post results in summary | ||
| run: | | ||
| echo "# 'ethrex' lines of code report" >> $GITHUB_STEP_SUMMARY | ||
| cat loc_report_github.txt >> $GITHUB_STEP_SUMMARY | ||
|
|
||
| - name: Post results to ethrex L1 slack channel | ||
|
|
@@ -159,6 +163,13 @@ jobs: | |
| url: ${{ secrets.LEVM_SLACK_WEBHOOK }} | ||
| run: sh .github/scripts/publish_loc.sh | ||
|
There was a problem hiding this comment. why are we removing this line? isn't it needed? There was a problem hiding this comment. Yes! That's why I was getting an error. I deleted the line by mistake. There was a problem hiding this comment. Fixed here: ef7bd71 |
||
|
|
||
| # This is left commented out to ease debugging later on. | ||
| # Comment out all the other "Post to * slack channel" directives | ||
| # - name: Post results to test slack channel | ||
| # env: | ||
| # url: ${{ secrets.TEST_CHANNEL_SLACK }} | ||
| # run: sh .github/scripts/publish_loc.sh | ||
|
|
||
| levm-test: | ||
| name: Generate Report for LEVM EF Tests | ||
| runs-on: ubuntu-latest | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this directive here to read the
loc_report.jsonthat was saved in the cache.