-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(l1): fix the transactions spammer count diff with our node #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transaction-spammer-count-diff
…rice in the same implementation
|
…as in the eip1559 tx for test
rodrigo-o
commented
Jan 8, 2025
mpaulucci
reviewed
Jan 8, 2025
mpaulucci
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As explained in this comment the spammer has a 2-phase execution, where
txcount * accounts
define the number of transactions added in the second phase of each round. We were recieving significant less transactions in the secod phase, nearaccounts
in numberDescription
This PR solves the issue adding a implementation of
eth_maxPriorityFeePerGas
, which after debuging proved to be the cause of the diminished number of transactions reaching our node. After an initial implementation we can see the node working as expected, here is a comparision:eth_maxPriorityFeePerGas
eth_maxPriorityFeePerGas
For the current implementation we extracted the common logic between
eth_GasPrice
andeth_maxPriorityFeePerGas
. This was inspired in how geth managed both. I moved the logic fromgas_price
to a common module (fee_calculator
) that calculates the gas tip; previously we were estimating the gas price, now the tip, this was the only change to the logic. Now both RPC calls depend on this logic, the difference beinggas_price
adding thebase_fee
whilemax_priority_fee
doesn't. I tried to avoid as much changes as possible to the previous implementation ofgas_price
, this is something that we might want to look further in the future.Resolves #1449