feat(levm): increase calldata cost - EIP-7623 #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check for gas limit restriction for being too low * Adjust gas used if it is under the floor * Adds TxValidationError for gas limit too low
|
fkrause98
reviewed
Jan 8, 2025
| @@ -169,6 +169,9 @@ pub const ACCESS_LIST_ADDRESS_COST: u64 = 2400; | |||
| // Precompile costs | |||
| pub const ECRECOVER_COST: u64 = 3000; | |||
|
|
|||
| // Floor price gas used | |||
| pub const TOTAL_COST_FLOOR_PER_TOKEN: u64 = 10; | |||
There was a problem hiding this comment.
Does this variable come from the EIP? If so, it'd be nice to link to were it comes from.
| } | ||
|
|
||
| fn add_intrinsic_gas(&mut self, initial_call_frame: &mut CallFrame) -> Result<(), VMError> { | ||
| // Intrinsic gas is the gas consumed by the transaction before the execution of the opcodes. Section 6.2 in the Yellow Paper. |
There was a problem hiding this comment.
Great, thanks for clarfying from where this comes from.
crates/vm/levm/src/vm.rs
Outdated
Comment on lines
612
to
618
| // tokens_in_calldata = tx_calldata / 4 | ||
| let tokens_in_calldata: u64 = gas_cost::tx_calldata(¤t_call_frame.calldata) | ||
| .map_err(VMError::OutOfGas)? | ||
| .checked_div(4) | ||
| .ok_or(VMError::Internal(InternalError::DivisionError))?; | ||
|
|
||
| // floor_gas_price = TX_BASE_COST + TOTAL_COST_FLOOR_PER_TOKEN * tokens_in_calldata |
There was a problem hiding this comment.
Same as above, where does this logic come from? Also, why divide by 4?
Benchmark Results ComparisonPR ResultsBenchmark Results: Factorial
Benchmark Results: Fibonacci
Main ResultsBenchmark Results: Factorial
Benchmark Results: Fibonacci
|
|
Before reviewing the PR:
The PR description looks very good! |
ilitteri
approved these changes
Jan 8, 2025
tomip01
added
ef-tests
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This Pull Request exists to make a floor cost for the gas usage in the transactions. This is specified in EIP-7623, and aims to reduce the maximum block size to make room for additional blobs or potential block gas limit increases. Also, it introduces that the gas limit has to be at least the floor cost.
Description
Here, for the Prague Spec adds the check in the
prepare_executionto the gas limit be greater or equal to the max value of the intrinsic gas orTX_BASE_COST + TOTAL_COST_FLOOR_PER_TOKEN * tokens_in_calldata. WhereTOTAL_COST_FLOOR_PER_TOKENis a new constant with the value of 10.A new error is added when the gas limit is too low,
TxValidationError::GasLimitTooLow.Then when creating the report, the gas usage for Prague is the max value of the gas usage or
TX_BASE_COST + TOTAL_COST_FLOOR_PER_TOKEN * tokens_in_calldata.State
The only tests for this EIP that fail are the test with type 4 transactions. This is because we don't have implemented them.
Closes #1640