-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(l2): replace ExecutionDB
from_exec()
impl to use a CacheDB
based approach
#1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fborello-lambda
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the prover compiles and the test make perf-risc0
passes.
We have to keep in mind that the blocks used for testing contain just plain transfers.
I think that #1705 will provide more insight and test-cases.
xqft
changed the title
fix(l2): replace
fix(l2): replace Jan 20, 2025
ExecutionDB
from_exec()
with IndexDB
ExecutionDB
from_exec()
with CacheDB
xqft
changed the title
fix(l2): replace
fix(l2): replace Jan 20, 2025
ExecutionDB
from_exec()
with CacheDB
ExecutionDB
from_exec()
impl to use a CacheDB
based approach
ilitteri
approved these changes
Jan 21, 2025
jrchatruc
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A
ExecutionDB
is created from a block's pre-execution but the current implementation is incorrect and not all needed data gets stored. The goal is to replace this with another approach, using an auxiliary "caching" database that will retrieve data from aStore
or an RPC endpoint (like in #1705) during the pre-execution of a block, finally resulting in a db that contains all the needed execution data.Description
ExecutionDB::from_exec()
to use theCacheDB
, rename it tofrom_store()