Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(l1): use levm flag for apply transaction function #1755

Merged
merged 16 commits into from
Jan 21, 2025
Merged

fix(l1): use levm flag for apply transaction function #1755

merged 16 commits into from
Jan 21, 2025

Conversation

lima-limon-inc
Copy link
Contributor

@lima-limon-inc lima-limon-inc commented Jan 20, 2025 •
edited
Loading

Motivation
We are using revm for the apply_plain_transaction function; regardless of the EVM implementation passed as a CLI argument.

With this PR, said function will now use the EVM implementation specified via CLI flags and will default to LEVM.

Description

Add both the LEVM and REVM code inside the apply_plain_transaction function. Only the specified implementation gets compiled.

Closes #1746

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading 

| File                                                         | Lines | Diff |
+--------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/blockchain/payload.rs | 515   | +35  |
+--------------------------------------------------------------+-------+------+

Total lines added: +35
Total lines removed: 0
Total lines changed: 35

@lima-limon-inc lima-limon-inc changed the title WIP Use levm when applying transactions fix(l1): use levm flag for apply transaction function Jan 20, 2025
@lima-limon-inc lima-limon-inc self-assigned this Jan 20, 2025
lima-limon-inc
lima-limon-inc commented Jan 20, 2025
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@lima-limon-inc lima-limon-inc marked this pull request as ready for review January 20, 2025 21:01
@lima-limon-inc lima-limon-inc requested a review from a team as a code owner January 20, 2025 21:01
@ilitteri ilitteri added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 6ae508e Jan 21, 2025
19 checks passed
@ilitteri ilitteri deleted the l1/fix/apply_transaction_levm branch January 21, 2025 14:47
@ilitteri ilitteri mentioned this pull request Jan 22, 2025
Closed
fborello-lambda added a commit that referenced this pull request Jan 29, 2025
@fborello-lambda
Revert "fix(l1): use levm flag for apply transaction function (#1755)"
8685b54 
This reverts commit 6ae508e.
github-merge-queue bot pushed a commit that referenced this pull request Jan 29, 2025
@fborello-lambda
revert(l1): use levm flag for apply transaction function (#1755) (#1832)
c9c77e3 
This reverts commit 6ae508e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilitteri ilitteri ilitteri approved these changes

Assignees

@lima-limon-inc lima-limon-inc

Labels
L1
Projects
ethrex_l1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LEVM: Check we're using levm everywhere
2 participants
@lima-limon-inc @ilitteri