fix(l1): modify the RPC eth_feeHistory controller implementation
#1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ilitteri
reviewed
Jan 24, 2025
| (base_fee_per_gas[idx + 1], base_fee_per_blob_gas[idx + 1]) = | ||
| project_next_block_base_fee_values(&header); | ||
| } | ||
| if self.reward_percentiles.len() > 0 { |
There was a problem hiding this comment.
Nit.
Suggested change
| if self.reward_percentiles.len() > 0 { | |
| if !self.reward_percentiles.len().is_empty() { |
ilitteri
reviewed
Jan 24, 2025
| "Expected param to be 0x prefixed".to_owned(), | ||
| ))?; | ||
| let block_count: u64 = | ||
| parse_json_hex(¶ms[0]).map_err(|error| RpcErr::BadParams(error))?; |
There was a problem hiding this comment.
Nit.
Suggested change
| parse_json_hex(¶ms[0]).map_err(|error| RpcErr::BadParams(error))?; | |
| parse_json_hex(¶ms[0]).map_err(RpcErr::BadParams)?; |
ilitteri
reviewed
Jan 24, 2025
ilitteri
changed the title
eth_feeHistory controller implementationeth_feeHistory controller implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the implementation of the
eth_feeHistoryRPC endpoint, by adding some new validations and modifying how the projected values ofbase_fee_per_gasandbase_fee_per_blobare obtained.Note
There is a hive test related to this endpoint which is still not passing, due to the requirement of supporting the Prague update by the execution client. Anyways, the results obtained from this test were compared with Geth and there are the same.