Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(core): do not require ef-test pr comment #1818

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Conversation

fborello-lambda
Copy link
Contributor

Motivation

The PR comment was a required CI job, making impossible to merge external contributions.

Description

  • Running the ef-tests is a required step.
  • The PR comment is not required anymore.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@fborello-lambda fborello-lambda self-assigned this Jan 28, 2025
@fborello-lambda fborello-lambda requested a review from a team as a code owner January 28, 2025 15:40
@fborello-lambda fborello-lambda changed the title fix(ci): do not require ef-test pr comment ci(core): do not require ef-test pr comment Jan 28, 2025
Copy link

github-actions bot commented Jan 28, 2025

Total lines added: 0
Total lines removed: 0
Total lines changed: 0

Copy link

Summary: 6475/6475 (100.00%)

Prague: 2373/2373 (100.00%)
Cancun: 3579/3579 (100.00%)
Shanghai: 221/221 (100.00%)
Merge: 62/62 (100.00%)
London: 39/39 (100.00%)
Berlin: 35/35 (100.00%)
Istanbul: 34/34 (100.00%)
Constantinople: 66/66 (100.00%)
Byzantium: 33/33 (100.00%)
Homestead: 17/17 (100.00%)
Frontier: 16/16 (100.00%)

Copy link

github-actions bot commented Jan 28, 2025

Benchmark Results Comparison

PR Results

Benchmark Results: Factorial

Command Mean [s] Min [s] Max [s] Relative
revm_factorial 7.525 ± 1.093 6.989 9.612 1.00
levm_factorial 26.121 ± 0.322 25.880 26.954 3.47 ± 0.51

Benchmark Results: Fibonacci

Command Mean [s] Min [s] Max [s] Relative
revm_fibonacci 7.545 ± 0.221 7.406 8.115 1.00
levm_fibonacci 23.695 ± 0.640 23.379 25.498 3.14 ± 0.13

Main Results

Benchmark Results: Factorial

Command Mean [s] Min [s] Max [s] Relative
revm_factorial 7.106 ± 0.018 7.062 7.125 1.00
levm_factorial 26.122 ± 0.172 25.804 26.389 3.68 ± 0.03

Benchmark Results: Fibonacci

Command Mean [s] Min [s] Max [s] Relative
revm_fibonacci 7.699 ± 0.704 7.361 9.646 1.00
levm_fibonacci 23.598 ± 0.110 23.452 23.788 3.06 ± 0.28

@ilitteri ilitteri added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit dcc90bf Jan 28, 2025
28 checks passed
@ilitteri ilitteri deleted the ci/fix_required_check branch January 28, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants