feat(levm): add support for EIP-7840 and add `EVMConfig` to LEVM. #1860

lima-limon-inc · 2025-01-31T13:58:38Z

Motivation

PR #1810 introduced support for EIP-7840 in L1. That EIP introduced the notion that certain blobhash related constants could be modified by Genesis file (for more information see commit: 8610b4c).

Description

This introduces a new struct called EVMConfig to LEVM. It only holds the current Fork and the desired ForkBlobSchedule.

In most cases, the default ForkBlobSchedule will want to be used (for that purpose, the EVMConfig::canonical_values(fork: Fork) -> ForkBlobSchedule functions exists). This is unless you want to use a custom ForkBlobSchedule like described in EIP-7840.

Closes #1813

github-actions · 2025-01-31T14:01:35Z

| File                                                                    | Lines | Diff |
+-------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/cmd/ef_tests/levm/runner/levm_runner.rs | 395   | +3   |
+-------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/blockchain/payload.rs            | 646   | +10  |
+-------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/environment.rs       | 37    | +1   |
+-------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/utils.rs             | 431   | -13  |
+-------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/vm.rs                | 761   | +59  |
+-------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/vm.rs                         | 841   | +3   |
+-------------------------------------------------------------------------+-------+------+

Total lines added: +76
Total lines removed: 13
Total lines changed: 89

github-actions · 2025-01-31T14:13:09Z

Benchmark Results Comparison

PR Results

Benchmark Results: Factorial

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`revm_Factorial`	239.1 ± 3.1	235.1	243.2	1.00
`levm_Factorial`	907.0 ± 8.8	899.3	925.3	3.79 ± 0.06

Benchmark Results: Factorial - Recursive

Command	Mean [s]	Min [s]	Max [s]	Relative
`revm_FactorialRecursive`	1.494 ± 0.071	1.427	1.655	1.00
`levm_FactorialRecursive`	15.584 ± 0.027	15.559	15.636	10.43 ± 0.50

Benchmark Results: Fibonacci

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`revm_Fibonacci`	209.5 ± 1.2	208.4	211.9	1.00
`levm_Fibonacci`	919.3 ± 26.4	895.0	967.8	4.39 ± 0.13

Benchmark Results: ManyHashes

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`revm_ManyHashes`	8.8 ± 0.1	8.7	8.8	1.00
`levm_ManyHashes`	18.1 ± 0.3	17.8	18.7	2.06 ± 0.03

Benchmark Results: BubbleSort

Command	Mean [s]	Min [s]	Max [s]	Relative
`revm_BubbleSort`	3.229 ± 0.023	3.203	3.264	1.00
`levm_BubbleSort`	6.046 ± 0.031	6.001	6.092	1.87 ± 0.02

Benchmark Results: ERC20 - Transfer

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`revm_ERC20Transfer`	252.9 ± 0.8	251.4	254.1	1.00
`levm_ERC20Transfer`	3223.6 ± 23.5	3188.8	3262.3	12.74 ± 0.10

Benchmark Results: ERC20 - Mint

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`revm_ERC20Mint`	143.2 ± 0.4	142.6	143.8	1.00
`levm_ERC20Mint`	1692.0 ± 12.8	1676.8	1709.7	11.82 ± 0.10

Benchmark Results: ERC20 - Approval

Command	Mean [s]	Min [s]	Max [s]	Relative
`revm_ERC20Approval`	1.048 ± 0.009	1.037	1.067	1.00
`levm_ERC20Approval`	11.383 ± 0.099	11.268	11.525	10.86 ± 0.13

Main Results

Benchmark Results: Factorial

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`revm_Factorial`	236.8 ± 0.7	235.6	238.0	1.00
`levm_Factorial`	905.7 ± 11.2	895.7	927.7	3.82 ± 0.05

Benchmark Results: Factorial - Recursive

Command	Mean [s]	Min [s]	Max [s]	Relative
`revm_FactorialRecursive`	1.561 ± 0.088	1.431	1.706	1.00
`levm_FactorialRecursive`	15.599 ± 0.032	15.559	15.661	9.99 ± 0.56

Benchmark Results: Fibonacci

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`revm_Fibonacci`	209.4 ± 1.2	208.3	211.8	1.00
`levm_Fibonacci`	918.3 ± 20.0	891.8	963.3	4.39 ± 0.10

Benchmark Results: ManyHashes

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`revm_ManyHashes`	9.1 ± 0.9	8.7	11.7	1.00
`levm_ManyHashes`	18.2 ± 0.1	18.1	18.4	2.01 ± 0.21

Benchmark Results: BubbleSort

Command	Mean [s]	Min [s]	Max [s]	Relative
`revm_BubbleSort`	3.258 ± 0.033	3.224	3.312	1.00
`levm_BubbleSort`	6.061 ± 0.036	6.018	6.125	1.86 ± 0.02

Benchmark Results: ERC20 - Transfer

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`revm_ERC20Transfer`	253.9 ± 2.3	251.7	259.0	1.00
`levm_ERC20Transfer`	3219.1 ± 28.9	3182.7	3249.4	12.68 ± 0.16

Benchmark Results: ERC20 - Mint

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`revm_ERC20Mint`	144.0 ± 1.1	142.6	146.0	1.00
`levm_ERC20Mint`	1698.4 ± 10.0	1679.7	1707.0	11.79 ± 0.12

Benchmark Results: ERC20 - Approval

Command	Mean [s]	Min [s]	Max [s]	Relative
`revm_ERC20Approval`	1.061 ± 0.014	1.047	1.090	1.00
`levm_ERC20Approval`	11.350 ± 0.117	11.241	11.502	10.70 ± 0.18

…en a fork

github-actions · 2025-01-31T17:55:22Z

…mandatory

github-actions · 2025-01-31T18:29:09Z

…ock of EVMConfig

This reverts commit b565207.

crates/vm/levm/src/vm.rs

ilitteri

LGTM. Left some comments about the documentation

Co-authored-by: Ivan Litteri <[email protected]>

fborello-lambda

👍

github-actions · 2025-02-03T12:52:31Z

crates/blockchain/payload.rs

crates/vm/vm.rs

fkrause98 · 2025-02-03T16:31:00Z

crates/vm/levm/src/constants.rs

+pub const TARGET_BLOB_GAS_PER_BLOCK: u64 = 393216; // TARGET_BLOB_NUMBER_PER_BLOCK * GAS_PER_BLOB
+pub const TARGET_BLOB_GAS_PER_BLOCK_PECTRA: u64 = 786432; // TARGET_BLOB_NUMBER_PER_BLOCK * GAS_PER_BLOB

 pub const MIN_BASE_FEE_PER_BLOB_GAS: U256 = U256::one();

 // WARNING: Do _not_ use the BLOB_BASE_FEE_UPDATE_FRACTION_* family of
 // constants as is. Use the `get_blob_base_fee_update_fraction_value`
 // function instead
-pub const BLOB_BASE_FEE_UPDATE_FRACTION: U256 = U256([3338477, 0, 0, 0]);
-pub const BLOB_BASE_FEE_UPDATE_FRACTION_PRAGUE: U256 = U256([5007716, 0, 0, 0]); // Defined in [EIP-7691](https://eips.ethereum.org/EIPS/eip-7691)
+pub const BLOB_BASE_FEE_UPDATE_FRACTION: u64 = 3338477;
+pub const BLOB_BASE_FEE_UPDATE_FRACTION_PRAGUE: u64 = 5007716; // Defined in [EIP-7691](https://eips.ethereum.org/EIPS/eip-7691)

 // WARNING: Do _not_ use the MAX_BLOB_COUNT_* family of constants as
 // is. Use the `max_blobs_per_block` function instead
-pub const MAX_BLOB_COUNT: usize = 6;
-pub const MAX_BLOB_COUNT_ELECTRA: usize = 9;
+pub const MAX_BLOB_COUNT: u64 = 6;
+pub const MAX_BLOB_COUNT_ELECTRA: u64 = 9;


Why these changes from U256 to u64?

Those functions are now only used int the EVMConfig struct. That struct has a ForkBlobSchedule inside it, which uses u64 for all it fields (Note: ForkBlobSchedule is used by the L1).

So, it the constants were left as U256 they were needed to be cast down; which returned a Result, whose Err case needed to be handled. This made it difficult to create a config since it could "technically" fail, even though it was casting down a constant.

I decided to change them to u64 in order to make it easier to use ForkBlobSchedule. Furthermore, casting a u64 to U256 doesn't return a Result; so there was no Err to handle.

fkrause98 · 2025-02-03T16:33:28Z

crates/vm/levm/src/utils.rs

-pub const fn max_blobs_per_block(fork: Fork) -> usize {
-    match fork {
-        Fork::Prague => MAX_BLOB_COUNT_ELECTRA,
-        Fork::PragueEof => MAX_BLOB_COUNT_ELECTRA,
-        _ => MAX_BLOB_COUNT,
-    }
-}
-
-/// According to EIP-7691
-/// (https://eips.ethereum.org/EIPS/eip-7691#specification):
-///
-/// "These changes imply that get_base_fee_per_blob_gas and
-/// calc_excess_blob_gas functions defined in EIP-4844 use the new
-/// values for the first block of the fork (and for all subsequent
-/// blocks)."
-
-pub const fn get_blob_base_fee_update_fraction_value(fork: Fork) -> U256 {
-    match fork {
-        Fork::Prague => BLOB_BASE_FEE_UPDATE_FRACTION_PRAGUE,
-        Fork::PragueEof => BLOB_BASE_FEE_UPDATE_FRACTION_PRAGUE,
-        _ => BLOB_BASE_FEE_UPDATE_FRACTION,
-    }
-}
-


I don't fully understand why we removed these functions

They were moved to the EVMConfig struct here: https://github.com/lambdaclass/ethrex/pull/1860/files#diff-e20d30a6efb08393eee586d44f3bc4a8df6cbd53ec8ea5bb4d5def88c9487de1R111-R133

fkrause98 · 2025-02-03T16:40:12Z

crates/vm/levm/src/vm.rs

+        }
+    }
+
+    /// According to [EIP-7691](https://eips.ethereum.org/EIPS/eip-7691#specification):


Great work documenting the corresponding EIPs 👍

Thanks 😊

github-actions · 2025-02-03T17:27:03Z

Add EVMConfig struct and add it to the environment

eef2e76

lima-limon-inc added the levm Lambda EVM implementation label Jan 31, 2025

lima-limon-inc self-assigned this Jan 31, 2025

lima-limon-inc added 4 commits January 31, 2025 11:25

Make execute_tx_levm receive a EVMConfig as a parameter

acc71b5

Make beacon_root_contract_call_levm use a reference to the EVMState

2cc7d6a

Make beacon_root_contract receive a EVMConfig

0da7991

Add get_canonical_values function to create a "default" EVMConfig giv…

caa9886

…en a fork

lima-limon-inc added 2 commits January 31, 2025 14:59

Use canonical function to build EVM config for the EF tests.

40eb947

Remove Option from the ForkBlobSchedule in EVMConfig, make it always …

8c701a3

…mandatory

lima-limon-inc force-pushed the levm/feat/eip7840 branch from 2d94528 to 8c701a3 Compare January 31, 2025 18:28

lima-limon-inc added 12 commits January 31, 2025 15:40

Move the const functions that access the constants inside the impl bl…

399ac2d

…ock of EVMConfig

Use EVMConfig for max blobs per block

8b3d881

Fix linter erorrs

c3512da

Use EVMConfigError for EVMConfig

f0a4b50

Merge branch 'main' into levm/feat/eip7840

7777eb2

DEBUG COMMIT: Debug CI

b565207

Make all the blobhash constants u64

0b49bbf

Make the canonical_values always return a valid value; no Return type

d5df202

Implement default trait for EVMConfig

eb81981

Remove EVMConfigError

542d331

Cast u64 to U256 in tests.rs

b032a16

Merge branch 'main' into levm/feat/eip7840

6404cfe

lima-limon-inc changed the title ~~feat(levm): add support for EIP-7840 and add ChainConfig to LEVM.~~ feat(levm): add support for EIP-7840 and add EVMConfig to LEVM. Jan 31, 2025

lima-limon-inc added 3 commits January 31, 2025 18:03

Use new funciton instead of building struct by hand.

28aa9b7

Revert "DEBUG COMMIT: Debug CI"

db5e6b4

This reverts commit b565207.

Restore comment

5f0566b

ilitteri reviewed Jan 31, 2025

View reviewed changes

crates/vm/levm/src/vm.rs Outdated Show resolved Hide resolved

ilitteri reviewed Jan 31, 2025

View reviewed changes

crates/vm/levm/src/vm.rs Outdated Show resolved Hide resolved

ilitteri reviewed Jan 31, 2025

View reviewed changes

crates/vm/levm/src/vm.rs Outdated Show resolved Hide resolved

ilitteri reviewed Jan 31, 2025

View reviewed changes

crates/vm/levm/src/vm.rs Outdated Show resolved Hide resolved

ilitteri approved these changes Jan 31, 2025

View reviewed changes

lima-limon-inc and others added 2 commits February 3, 2025 09:27

Update crates/vm/levm/README.md

93d1c28

Co-authored-by: Ivan Litteri <[email protected]>

Update crates/vm/levm/src/vm.rs

785b2b4

Co-authored-by: Ivan Litteri <[email protected]>

tomip01 approved these changes Feb 3, 2025

View reviewed changes

lima-limon-inc and others added 4 commits February 3, 2025 09:30

Use or in patter matching for fork

81759fe

Update crates/vm/levm/src/vm.rs

beca9b8

Co-authored-by: Ivan Litteri <[email protected]>

Update crates/vm/levm/src/vm.rs

04be9b0

Co-authored-by: Ivan Litteri <[email protected]>

Update crates/vm/levm/src/vm.rs

1838bae

Co-authored-by: Ivan Litteri <[email protected]>

fborello-lambda approved these changes Feb 3, 2025

View reviewed changes

Merge branch 'main' into levm/feat/eip7840

a3151ac

Add EVMConfig to fork

29a280e

lima-limon-inc marked this pull request as draft February 3, 2025 14:17

lima-limon-inc commented Feb 3, 2025

View reviewed changes

crates/blockchain/payload.rs Show resolved Hide resolved

crates/vm/vm.rs Show resolved Hide resolved

lima-limon-inc marked this pull request as ready for review February 3, 2025 15:01

fkrause98 reviewed Feb 3, 2025

View reviewed changes

Solve conflicts

04ab00c

lima-limon-inc force-pushed the levm/feat/eip7840 branch from ab0a37e to 04ab00c Compare February 3, 2025 17:28

fkrause98 approved these changes Feb 3, 2025

View reviewed changes

lima-limon-inc added this pull request to the merge queue Feb 3, 2025

Merged via the queue into main with commit dec0119 Feb 3, 2025
34 checks passed

lima-limon-inc deleted the levm/feat/eip7840 branch February 3, 2025 18:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(levm): add support for EIP-7840 and add `EVMConfig` to LEVM. #1860

feat(levm): add support for EIP-7840 and add `EVMConfig` to LEVM. #1860

lima-limon-inc commented Jan 31, 2025 •

edited

Loading

github-actions bot commented Jan 31, 2025 •

edited

Loading

github-actions bot commented Jan 31, 2025 •

edited

Loading

github-actions bot commented Jan 31, 2025

github-actions bot commented Jan 31, 2025

ilitteri left a comment

fborello-lambda left a comment

github-actions bot commented Feb 3, 2025

fkrause98 Feb 3, 2025

lima-limon-inc Feb 3, 2025

fkrause98 Feb 3, 2025

lima-limon-inc Feb 3, 2025

fkrause98 Feb 3, 2025

lima-limon-inc Feb 3, 2025

github-actions bot commented Feb 3, 2025

feat(levm): add support for EIP-7840 and add EVMConfig to LEVM. #1860

feat(levm): add support for EIP-7840 and add EVMConfig to LEVM. #1860

Conversation

lima-limon-inc commented Jan 31, 2025 • edited Loading

github-actions bot commented Jan 31, 2025 • edited Loading

github-actions bot commented Jan 31, 2025 • edited Loading

Benchmark Results Comparison

PR Results

Benchmark Results: Factorial

Benchmark Results: Factorial - Recursive

Benchmark Results: Fibonacci

Benchmark Results: ManyHashes

Benchmark Results: BubbleSort

Benchmark Results: ERC20 - Transfer

Benchmark Results: ERC20 - Mint

Benchmark Results: ERC20 - Approval

Main Results

Benchmark Results: Factorial

Benchmark Results: Factorial - Recursive

Benchmark Results: Fibonacci

Benchmark Results: ManyHashes

Benchmark Results: BubbleSort

Benchmark Results: ERC20 - Transfer

Benchmark Results: ERC20 - Mint

Benchmark Results: ERC20 - Approval

github-actions bot commented Jan 31, 2025

github-actions bot commented Jan 31, 2025

ilitteri left a comment

Choose a reason for hiding this comment

fborello-lambda left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 3, 2025

fkrause98 Feb 3, 2025

Choose a reason for hiding this comment

lima-limon-inc Feb 3, 2025

Choose a reason for hiding this comment

fkrause98 Feb 3, 2025

Choose a reason for hiding this comment

lima-limon-inc Feb 3, 2025

Choose a reason for hiding this comment

fkrause98 Feb 3, 2025

Choose a reason for hiding this comment

lima-limon-inc Feb 3, 2025

Choose a reason for hiding this comment

github-actions bot commented Feb 3, 2025

feat(levm): add support for EIP-7840 and add `EVMConfig` to LEVM. #1860

feat(levm): add support for EIP-7840 and add `EVMConfig` to LEVM. #1860

lima-limon-inc commented Jan 31, 2025 •

edited

Loading

github-actions bot commented Jan 31, 2025 •

edited

Loading

github-actions bot commented Jan 31, 2025 •

edited

Loading