feat(l1): add Mekong presets #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mpaulucci
reviewed
Jan 31, 2025
| @@ -114,6 +114,13 @@ async fn main() { | |||
| bootnodes = networks::SEPOLIA_BOOTNODES.to_vec(); | |||
| } | |||
|
|
|||
| if network == "mekong" { | |||
| warn!("Using mekong presets, bootnodes field will be ignored"); | |||
There was a problem hiding this comment.
instead of ignoring the bootnodes field, shouldn't we append it? Thoughts?
There was a problem hiding this comment.
Good idea, we should add that logic to the other networks too
mpaulucci
reviewed
Jan 31, 2025
|
|
||
| pub const HOLESKY_BOOTNODES_PATH: &str = "cmd/ethrex/networks/holesky/bootnodes.json"; | ||
| pub const SEPOLIA_BOOTNODES_PATH: &str = "cmd/ethrex/networks/sepolia/bootnodes.json"; | ||
| pub const MEKONG_BOOTNODES_PATH: &str = "cmd/ethrex/networks/mekong/bootnodes.json"; |
There was a problem hiding this comment.
I forgot to push them, should be up now
mpaulucci
approved these changes
Jan 31, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This testnet is much newer than holesky, so It should allow us to test snap sync much faster
Description
Closes #issue_number