fix(l1): log transaction errors instead of disconnecting #1863
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, if we fail to process transactions received from peers, we propagate the error until we disconnect from them. This is incorrect behavior because we might be one block behind the current head and invalidating transactions for insufficient balance.
Description
BlobViolations
Hive test, which was a false positive. We have L1 P2P: validate transaction type and size inPooledTransactions
message #1781 to fix this.Transactions
message, filters and propagates only the valid transactions. This change brakes the Hive testeth/InvalidTxs
, which was also a false positive since we are incorrectly considering valid two transactions in the test. InvalidTxs #1139 was created to fix this.