Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(l1): log transaction errors instead of disconnecting #1863

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

avilagaston9
Copy link
Contributor

Motivation

Currently, if we fail to process transactions received from peers, we propagate the error until we disconnect from them. This is incorrect behavior because we might be one block behind the current head and invalidating transactions for insufficient balance.

Description

@avilagaston9 avilagaston9 self-assigned this Jan 31, 2025
@avilagaston9 avilagaston9 marked this pull request as ready for review January 31, 2025 16:14
@avilagaston9 avilagaston9 requested a review from a team as a code owner January 31, 2025 16:14
Copy link

| File                                                                           | Lines | Diff |
+--------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/rlpx/connection.rs       | 394   | +6   |
+--------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/rlpx/eth/transactions.rs | 288   | +8   |
+--------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/rlpx/utils.rs            | 83    | +3   |
+--------------------------------------------------------------------------------+-------+------+

Total lines added: +17
Total lines removed: 0
Total lines changed: 17

1 similar comment
Copy link

| File                                                                           | Lines | Diff |
+--------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/rlpx/connection.rs       | 394   | +6   |
+--------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/rlpx/eth/transactions.rs | 288   | +8   |
+--------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/rlpx/utils.rs            | 83    | +3   |
+--------------------------------------------------------------------------------+-------+------+

Total lines added: +17
Total lines removed: 0
Total lines changed: 17

Copy link
Collaborator

@mpaulucci mpaulucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mpaulucci mpaulucci added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 882e1e2 Jan 31, 2025
20 checks passed
@mpaulucci mpaulucci deleted the l1/fix/log_transaction_errors branch January 31, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants