-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(l1): improve healing #1867
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to add-holesky-presets
…to add-sepolia-presets
|
mpaulucci
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Reverts the "slow but safe" approach to healing taken by #1763 and instead adds the intermediate nodes received from peers to the trie.
Description
Comments
A not so pretty solution was implemented on the storage_healer (the startup flag) to avoid blocking storage healing at the start. This can and will be improved but doing so in this PR is not worth it when follow up PRs will already touch up on this logic when parallelizing storage node fetching (similar to storage ranges)
Testing
This proved to work fine in
Mekong
testnet when introducing forced sleeps and delays to force healing. But it is still too slow to work on Holesky testnet, this should improve once we add more parallelization to state sync & healingCloses #issue_number