feat(l1): parallelize node requests during snap sync healing phase #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mpaulucci
reviewed
Feb 4, 2025
crates/networking/p2p/sync.rs
Outdated
| trie.state_mut().write_node(node, hash)?; | ||
| } | ||
| // Send storage & bytecode requests | ||
| if !hahsed_addresses.is_empty() { |
There was a problem hiding this comment.
Nice catch! fixed all instances
mpaulucci
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Spawn multiple concurrent fetch processes for state & storage nodes (similar to storage ranges) in order to speed up healing phase.
Description
MAX_PARALLEL_FETCHESconstant to limit and customize how many concurrent fetch processes can be spawned at a time when fetching storage ranges, state nodes and storage nodesrecv_manyon the storage healer to avoid piling up storage heal requestsCloses #issue_number