Add basic test setup for era_vm #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
MarcosNicolau
force-pushed
the
era_vm_tests_v2
branch
from
880a07c to
12eae0a
Compare
fkrause98
reviewed
Aug 16, 2024
| @@ -17,7 +17,7 @@ zk_evm_1_4_0.workspace = true | |||
| zk_evm_1_3_3.workspace = true | |||
| zk_evm_1_3_1.workspace = true | |||
| vm2.workspace = true | |||
| era_vm = {path = "../../../../"} | |||
| era_vm = { path = "../../../../era_vm" } | |||
There was a problem hiding this comment.
This will not work when zksync-era is used as a submodule for era_vm, believe me I've tried. Please restore this.
There was a problem hiding this comment.
When developing, we can modify this as needed.
juan518munoz
changed the base branch from
era_vm_integration_v2
to
pubdata-refunds-adapt
Base automatically changed from
pubdata-refunds-adapt
to
era_vm_integration_v2
August 16, 2024 16:03
|
Closing this one in favor of #234. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This pr enables the tests under this folder to the lambda_vm. Merge once this pr gets merged.
Why ❔
This is to ensure all tests pass in the lambda_vm.
Checklist
zk fmtandzk lint.