-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM Simulator code hash in witness data #249
EVM Simulator code hash in witness data #249
Conversation
Hey there! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
|
.factory_deps_dal() | ||
.get_sealed_factory_dep(evm_simulator) | ||
.await? | ||
.ok_or_else(|| anyhow!("Default account bytecode should exist"))?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.ok_or_else(|| anyhow!("Default account bytecode should exist"))?; | |
.ok_or_else(|| anyhow!("EVM simulator bytecode should exist"))?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But generally, do we actually want to force it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least in this PR, it should be enforced just to check if everything on the prover side works okay. We have this other PR that makes the EVM simulator optional with a custom new flag, so maybe we can change this logic there to also make it optional here.
And now we also need to actually use it here: zksync-era/prover/crates/bin/witness_generator/src/basic_circuits.rs Lines 494 to 495 in 14e8f34
|
What ❔
Why ❔
Checklist
zk fmt
andzk lint
.