Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pending batches 404 #3

Closed
wants to merge 21 commits into from
Closed

fix pending batches 404 #3

wants to merge 21 commits into from

Commits on Oct 19, 2023

  1. chore: remove extra call to get_l1_batch_state_root (#176)

    Co-authored-by: Igor Borodin <[email protected]>
    zhiqiangxu and hatemosphere authored Oct 19, 2023
    Configuration menu
    Copy the full SHA
    34f3110 View commit details
    Browse the repository at this point in the history
  2. fix: Fix TxStage string representation (#255)

    # What ❔
    
    After transferring to vise metrics, `mempool_` transaction stage labels
    became incorrect (e.g., `mempool_Added` instead of `mempool_added`).
    This PR changes them back.
    
    ## Why ❔
    
    These labels are used on some internal Grafana dashboards.
    
    ## Checklist
    
    - [x] PR title corresponds to the body of PR (we generate changelog
    entries from PRs).
    - [ ] ~Tests for the changes have been added / updated.~ *not
    applicable*
    - [ ] ~Documentation comments have been added / updated.~ *not
    applicable*
    - [x] Code has been formatted via `zk fmt` and `zk lint`.
    slowli authored Oct 19, 2023
    Configuration menu
    Copy the full SHA
    246b5a0 View commit details
    Browse the repository at this point in the history
  3. chore: Mainnet protocol upgrade 16 data (#241)

    # What ❔
    
    Data for mainnet upgrade to version 16
    
    ## Checklist
    
    <!-- Check your PR fulfills the following items. -->
    <!-- For draft PRs check the boxes as you complete them. -->
    
    - [x] PR title corresponds to the body of PR (we generate changelog
    entries from PRs).
    - [ ] Tests for the changes have been added / updated.
    - [ ] Documentation comments have been added / updated.
    - [ ] Code has been formatted via `zk fmt` and `zk lint`.
    perekopskiy authored Oct 19, 2023
    Configuration menu
    Copy the full SHA
    f4ffcb9 View commit details
    Browse the repository at this point in the history
  4. refactor(en): Refactor sync action queue in EN (#243)

    # What ❔
    
    Refactors action queue used by EN to be more idiomatic. Covers sync
    logic with tests.
    
    ## Why ❔
    
    The idea is to reuse EN code other than the fetcher with the new sync
    mechanism that will be brought by consensus.
    
    ## Checklist
    
    - [x] PR title corresponds to the body of PR (we generate changelog
    entries from PRs).
    - [x] Tests for the changes have been added / updated.
    - [x] Documentation comments have been added / updated.
    - [x] Code has been formatted via `zk fmt` and `zk lint`.
    slowli authored Oct 19, 2023
    Configuration menu
    Copy the full SHA
    a135127 View commit details
    Browse the repository at this point in the history
  5. feat(eth-watch): process governor upgrades (#247)

    # What ❔
    
    With boojum upgrades will go through governor. PR adds functionality to
    process such upgrades while leaving old processor as well.
    
    ## Why ❔
    
    Prepare for boojum upgrade
    
    ## Checklist
    
    <!-- Check your PR fulfills the following items. -->
    <!-- For draft PRs check the boxes as you complete them. -->
    
    - [x] PR title corresponds to the body of PR (we generate changelog
    entries from PRs).
    - [x] Tests for the changes have been added / updated.
    - [x] Documentation comments have been added / updated.
    - [x] Code has been formatted via `zk fmt` and `zk lint`.
    perekopskiy authored Oct 19, 2023
    Configuration menu
    Copy the full SHA
    d250294 View commit details
    Browse the repository at this point in the history
  6. feat(reorg_detector): compare miniblock hashes for reorg detection (#236

    )
    
    # What ❔
    
    This PR adds logic to compare the L2 miniblock hashes to
    `reorg_detector` logic.
    
    ## Why ❔
    
    Currently `reorg_detector` only considers the L1 batches and their root
    hashes which
    in case of a reorg on the miniblock level leaves such reorg undetected
    and nodes stuck.
    montekki authored Oct 19, 2023
    Configuration menu
    Copy the full SHA
    2c930b2 View commit details
    Browse the repository at this point in the history
  7. fix: fix typos (#226)

    vuittont60 authored Oct 19, 2023
    Configuration menu
    Copy the full SHA
    feb8a6c View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. feat: Remove fee_ticker and token_trading_volume fetcher modules (#262)

    # What ❔
    
    - Removes `fee_ticker` module.
    - Removes `token_trading_volume` fetcher.
    - Removes some (now unused) methods from DAL.
    - Removes some (now unused) types.
    
    ## Why ❔
    
    Dead code.
    
    ## Checklist
    
    <!-- Check your PR fulfills the following items. -->
    <!-- For draft PRs check the boxes as you complete them. -->
    
    - [x] PR title corresponds to the body of PR (we generate changelog
    entries from PRs).
    - [ ] ~~Tests for the changes have been added / updated.~~
    - [ ] ~~Documentation comments have been added / updated.~~
    - [x] Code has been formatted via `zk fmt` and `zk lint`.
    popzxc authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    44f7179 View commit details
    Browse the repository at this point in the history
  2. feat(merkle tree): Snapshot recovery for Merkle tree (#163)

    # What ❔
    
    Allows to recover a Merkle tree from a snapshot (collection of tree
    entries ordered by ascending key). The recovery procedure is
    fault-tolerant (may be paused and restarted).
    
    ## Why ❔
    
    This is one of components for recovering a node from a snapshot.
    
    ## Checklist
    
    - [x] PR title corresponds to the body of PR (we generate changelog
    entries from PRs).
    - [x] Tests for the changes have been added / updated.
    - [x] Documentation comments have been added / updated.
    - [x] Code has been formatted via `zk fmt` and `zk lint`.
    slowli authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    9e20703 View commit details
    Browse the repository at this point in the history
  3. fix(crypto): update snark-vk to be used in server and update args for…

    … proof wrapping (#240)
    
    # What ❔
    
    * fix(crypto): update snark-vk to be used in server and update args for
    proof wrapping
    
    ## Why ❔
    
    * Rn the server sends the blob with protocol version using scheduler_vk
    which is different from the one used in prover(snark_scheduler_vk)
    
    ## Checklist
    
    <!-- Check your PR fulfills the following items. -->
    <!-- For draft PRs check the boxes as you complete them. -->
    
    - [ *] PR title corresponds to the body of PR (we generate changelog
    entries from PRs).
    - [ *] Tests for the changes have been added / updated.
    - [ *] Documentation comments have been added / updated.
    - [ *] Code has been formatted via `zk fmt` and `zk lint`.
    akash-chandrakar authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    4a5c54c View commit details
    Browse the repository at this point in the history
  4. fix: fix broken links (#267)

    # What ❔
    
    - fix broken links
    
    ## Why ❔
    
    - The link is no longer valid and cannot be opened.
    
    ## Checklist
    
    - [ ✅ ] PR title corresponds to the body of PR (we generate changelog
    entries from PRs).
    - [ ✅ ] Tests for the changes have been added / updated.
    - [ ✅ ] Documentation comments have been added / updated.
    - [ ✅ ] Code has been formatted via `zk fmt` and `zk lint`.
    ylmin authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    73a1e8f View commit details
    Browse the repository at this point in the history
  5. fix pending batches 404

    igamigo committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    ab08009 View commit details
    Browse the repository at this point in the history
  6. nl

    igamigo authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    de8d156 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. chore: Update Security link in README.MD (#282)

    # What ❔
    
    - update Security link in README.MD
    
    ## Why ❔
    
    - when you click on Security on README. it takes you to invalid link
    
    ## Checklist
    
    <!-- Check your PR fulfills the following items. -->
    <!-- For draft PRs check the boxes as you complete them. -->
    
    - [x] PR title corresponds to the body of PR (we generate changelog
    entries from PRs).
    - [ ] Tests for the changes have been added / updated.
    - [ ] Documentation comments have been added / updated.
    - [x] Code has been formatted via `zk fmt` and `zk lint`.
    oxJean authored Oct 22, 2023
    Configuration menu
    Copy the full SHA
    5010691 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. fix: fix documentation link (#280)

    # What ❔
    
    - fix documentation link
    
    ## Why ❔
    
    - The link cannot be accessed.
    
    ## Checklist
    
    <!-- Check your PR fulfills the following items. -->
    <!-- For draft PRs check the boxes as you complete them. -->
    
    - [x] PR title corresponds to the body of PR (we generate changelog
    entries from PRs).
    - [x] Tests for the changes have been added / updated.
    - [ ] Documentation comments have been added / updated.
    - [x] Code has been formatted via `zk fmt` and `zk lint`.
    moonchrisir authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    9dbb5b1 View commit details
    Browse the repository at this point in the history
  2. chore: Update docs (#283)

    # What ❔
    
    - Update docs
    
    ## Why ❔
    
    <img width="1184" alt="image"
    src="https://github.com/matter-labs/zksync-era/assets/148654386/0d1efcd4-4009-4f91-9f29-0b445bd2863a">
    
    ## Checklist
    
    
    - [x] PR title corresponds to the body of PR (we generate changelog
    entries from PRs).
    - [ ] Tests for the changes have been added / updated.
    - [ ] Documentation comments have been added / updated.
    - [x] Code has been formatted via `zk fmt` and `zk lint`.
    Dollyerls authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    b8a5e6d View commit details
    Browse the repository at this point in the history
  3. chore: updated era-zkevm_opcode_defs dependency (#287)

    # What ❔
    
    Updated the era-zkevm_opcode_defs dependency and minimal set of other
    dependencies which required update to a compatible version. This
    unlocked updated sha2 and sha3 dependencies to 0.10.8.
    Prover integration test run for extra safety:
    https://github.com/matter-labs/zksync-era-workflows/actions/runs/6612607366
    
    ## Why ❔
    
    To include matter-labs/era-zkevm_opcode_defs#16
    which in turn allows us to depend on up-to-date versions of sha2 and
    sha3.
    pompon0 authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    33e3192 View commit details
    Browse the repository at this point in the history
  4. fix(witness-generator): Witness generator oracle with cached storage …

    …refunds (#274)
    
    # What ❔
    
    During VM run in state keeper we save all storage refunds that are
    returned by oracle. Later in basic witness generation these refunds are
    reused.
    Also, `zk_evm` is updated so that it now passes correct timestamps for
    `estimate_refunds_for_write` queries. Correct timestamps are necessary
    for VM storage oracle to rollback `returned_refunds`
    
    ## Why ❔
    
    With new VM, pubdata tracer mutates oracle affecting storage refunds. As
    this tracer is only run in state keeper and not in witness generator we
    must save refunds from state keeper and use them in wit-gen.
    
    ## Checklist
    
    <!-- Check your PR fulfills the following items. -->
    <!-- For draft PRs check the boxes as you complete them. -->
    
    - [x] PR title corresponds to the body of PR (we generate changelog
    entries from PRs).
    - [x] Tests for the changes have been added / updated.
    - [x] Documentation comments have been added / updated.
    - [x] Code has been formatted via `zk fmt` and `zk lint`.
    perekopskiy authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    8928a41 View commit details
    Browse the repository at this point in the history
  5. fix(db): Fix write stalls in RocksDB (again) (#265)

    # What ❔
    
    RocksDB write stalls are still happening, this time for a different
    reason. Previously, they were caused by too many immutable memtables,
    this time – by too many level-0 SST files. This PR:
    
    - Tunes RocksDB options some more (the main tuning point is [optimizing
    level-style
    compaction](https://docs.rs/rocksdb/latest/rocksdb/struct.Options.html#method.optimize_level_style_compaction)).
    - Increases the number of retries on stall and introduces exponential
    backoff.
    - Introduces a dozen of RocksDB metrics that should help monitoring
    RocksDB health.
    
    ## Why ❔
    
    Having write stalls leads to panics and is obviously bad.
    
    ## Checklist
    
    - [x] PR title corresponds to the body of PR (we generate changelog
    entries from PRs).
    - [x] Tests for the changes have been added / updated.
    - [x] Documentation comments have been added / updated.
    - [x] Code has been formatted via `zk fmt` and `zk lint`.
    
    ---------
    
    Co-authored-by: AnastasiiaVashchuk <[email protected]>
    slowli and AnastasiiaVashchuk authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    7b23ab0 View commit details
    Browse the repository at this point in the history
  6. test(en): Test sync actions produced by main node fetcher (#268)

    # What ❔
    
    - Tests actions produced by the main node fetcher. As a side effect,
    adds a way to launch a JSON-RPC HTTP server in-process and adds a
    primitive test for it as well.
    - Refactors the main node fetcher slightly, extracting the EN–main node
    client interface to a trait.
    
    ## Why ❔
    
    - Creates reference action queue contents that may be tested against
    when an alternative fetcher based on the consensus gossip network is
    implemented.
    - Test coverage good.
    
    ## Checklist
    
    - [x] PR title corresponds to the body of PR (we generate changelog
    entries from PRs).
    - [x] Tests for the changes have been added / updated.
    - [x] Documentation comments have been added / updated.
    - [x] Code has been formatted via `zk fmt` and `zk lint`.
    slowli authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    0e5eefc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e816f7c View commit details
    Browse the repository at this point in the history