Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigenda memstore #305

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Eigenda memstore #305

merged 6 commits into from
Oct 18, 2024

Conversation

gianbelinche
Copy link

@gianbelinche gianbelinche commented Oct 16, 2024

What ❔

This PR adds memstore implementation for eigenda proxy

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk_supervisor fmt and zk_supervisor lint.

Copy link

github-actions bot commented Oct 16, 2024

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Examples of valid PR titles:

  • feat(eth_sender): Support new transaction type
  • fix(state_keeper): Correctly handle edge case
  • ci: Add new workflow for linting

Details:

No release type found in pull request title "Eigenda memstore". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@gianbelinche gianbelinche changed the base branch from da-eigen-implementation-m0 to eigenda_proxy_setup October 16, 2024 17:34
Base automatically changed from eigenda_proxy_setup to da-eigen-implementation-m0 October 16, 2024 17:47
@gianbelinche gianbelinche marked this pull request as ready for review October 16, 2024 19:16
Copy link

@juan518munoz juan518munoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The put & get method might be movable into a interface in a later revision.

@gianbelinche gianbelinche merged commit 8c79c06 into da-eigen-implementation-m0 Oct 18, 2024
11 of 23 checks passed
@gianbelinche gianbelinche deleted the eigenda_memstore branch October 18, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants