-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add eigenDA client protos #306
Conversation
Hey there! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
|
@@ -14,3 +14,9 @@ anyhow.workspace = true | |||
axum.workspace = true | |||
tokio.workspace = true | |||
tracing.workspace = true | |||
prost = "0.13.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prost
is available as a workspace
dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the prost version used workspace wide is older than the one required for tonic. I added a comment explaining that
@@ -0,0 +1,10 @@ | |||
syntax = "proto3"; | |||
package common; | |||
option go_package = "github.com/Layr-Labs/eigenda/api/grpc/common"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this go package?
Same with other files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the proto files just to know where the compiled code comes from.
e859ca2
into
da-eigen-implementation-m0
This PR adds the generated modules for the eigenDA protobuffs.
Auth will be implemented in another PR.