Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eigenDA client protos #306

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

juanbono
Copy link
Member

@juanbono juanbono commented Oct 16, 2024

This PR adds the generated modules for the eigenDA protobuffs.

Auth will be implemented in another PR.

Copy link

github-actions bot commented Oct 16, 2024

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Examples of valid PR titles:

  • feat(eth_sender): Support new transaction type
  • fix(state_keeper): Correctly handle edge case
  • ci: Add new workflow for linting

Details:

No release type found in pull request title "add eigenDA client protos". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@juanbono juanbono marked this pull request as ready for review October 17, 2024 19:00
@@ -14,3 +14,9 @@ anyhow.workspace = true
axum.workspace = true
tokio.workspace = true
tracing.workspace = true
prost = "0.13.1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prost is available as a workspace dependency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the prost version used workspace wide is older than the one required for tonic. I added a comment explaining that

@@ -0,0 +1,10 @@
syntax = "proto3";
package common;
option go_package = "github.com/Layr-Labs/eigenda/api/grpc/common";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this go package?
Same with other files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the proto files just to know where the compiled code comes from.

@gianbelinche gianbelinche merged commit e859ca2 into da-eigen-implementation-m0 Oct 18, 2024
11 of 23 checks passed
@gianbelinche gianbelinche deleted the add_eigenda_protos branch October 18, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants