forked from matter-labs/zksync-era
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authenticated Blob Dispersal #311
Closed
gianbelinche
wants to merge
11
commits into
da-eigen-implementation-m0
from
eigenda-authenticated-disperse
Closed
Authenticated Blob Dispersal #311
gianbelinche
wants to merge
11
commits into
da-eigen-implementation-m0
from
eigenda-authenticated-disperse
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
|
gianbelinche
changed the title
Implement first authenticated call
Authenticated Blob Dispersal
Oct 21, 2024
Base automatically changed from
eigenda-disperser-client
to
da-eigen-implementation-m0
October 24, 2024 14:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR implements
put_blob_authenticated
method forEigenDAClient
It does so by creating a channel were the first element of the stream is sent
zksync-era/core/node/eigenda_proxy/src/eigenda_client.rs
Line 184 in 37b36b8
Then that channel is transformed into a stream and sent to
disperse_blob_authenticated
, which returns another stream used for getting the responses.zksync-era/core/node/eigenda_proxy/src/eigenda_client.rs
Lines 197 to 204 in 37b36b8
Then the first request is processed, and its returned value is used for computing the signature needed for the second request.
zksync-era/core/node/eigenda_proxy/src/eigenda_client.rs
Lines 206 to 210 in 37b36b8
zksync-era/core/node/eigenda_proxy/src/eigenda_client.rs
Lines 216 to 225 in 37b36b8
Then that request is added to the sender stream, and its result is processed, completing the dispersal.
zksync-era/core/node/eigenda_proxy/src/eigenda_client.rs
Lines 226 to 233 in 37b36b8
Why ❔
Checklist
zk_supervisor fmt
andzk_supervisor lint
.