-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Eigenda disperser /get/
and /put/
endpoints
#313
feat: Eigenda disperser /get/
and /put/
endpoints
#313
Conversation
impl IntoResponse for RequestProcessorError { | ||
fn into_response(self) -> Response { | ||
unimplemented!("EigenDA request error into response") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be implemented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct, addressed in 680a207
core/node/eigenda_proxy/src/lib.rs
Outdated
EigenDAConfig::Disperser(disperser_config) => EigenDAClient::new(disperser_config) | ||
.await | ||
.map_err(|e| anyhow::anyhow!("Failed to create EigenDA client: {:?}", e))?, | ||
_ => panic!("memstore unimplemented"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next would be implementing this for memstore also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Working on it
What ❔
Why ❔
Checklist
zk_supervisor fmt
andzk_supervisor lint
.