Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Eigenda disperser /get/ and /put/ endpoints #313

Conversation

juan518munoz
Copy link

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk_supervisor fmt and zk_supervisor lint.

@juan518munoz juan518munoz marked this pull request as ready for review October 22, 2024 19:33
Comment on lines 25 to 28
impl IntoResponse for RequestProcessorError {
fn into_response(self) -> Response {
unimplemented!("EigenDA request error into response")
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be implemented?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, addressed in 680a207

EigenDAConfig::Disperser(disperser_config) => EigenDAClient::new(disperser_config)
.await
.map_err(|e| anyhow::anyhow!("Failed to create EigenDA client: {:?}", e))?,
_ => panic!("memstore unimplemented"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next would be implementing this for memstore also

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Working on it

Base automatically changed from eigenda-disperser-client to da-eigen-implementation-m0 October 24, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants