Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Use reagent components as parent & other small fixes #27

Draft
wants to merge 3 commits into
base: ornament-next
Choose a base branch
from
Draft

[WIP] Use reagent components as parent & other small fixes #27

wants to merge 3 commits into from

Conversation

oxalorg
Copy link
Member

@oxalorg oxalorg commented Aug 3, 2024 •
edited
Loading

  • Allows using reagent components as parents
  • README minor fixes
  • Preserve user options provided to set-tokens, and make pretty-print configurable for generated css

@oxalorg oxalorg changed the base branch from main to ornament-next August 3, 2024 17:00
plexus
plexus reviewed Aug 4, 2024
View reviewed changes
src/lambdaisland/ornament.cljc
@@ -46,6 +46,11 @@
props-registry
(atom {})))

#?(:clj
(defonce ^{:doc "Store of passed in custom options/tokens"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this about?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would store all the tokens set from different places and show the last overriden tokens. This means options like pretty-print? can then be accessed later in the ornament code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plexus plexus plexus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oxalorg @plexus @dcostaras