Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github action for lint and test #6

Merged
merged 24 commits into from
Jul 24, 2024
Merged

add github action for lint and test #6

merged 24 commits into from
Jul 24, 2024

Conversation

lambley
Copy link
Owner

@lambley lambley commented Jul 19, 2024

  • add workflow to run lint and test, and exit if either fail
  • add sonarless-scan - only check for vulnerabilities, code smells, duplications and coverage

@lambley
Copy link
Owner Author

lambley commented Jul 23, 2024

I'll add pushing to Azure Container registry to the CI actions

@WeaponOfChoice-Solirius
Copy link
Collaborator

As mentioned in our standup - please Dockerise the app, and include that in your CI workflow

Copy link
Collaborator

@WeaponOfChoice-Solirius WeaponOfChoice-Solirius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockerfile and build to ECR or similar
Add image build and deploy to ECS or similar

@lambley
Copy link
Owner Author

lambley commented Jul 23, 2024

Dockerfile and build to ECR or similar Add image build and deploy to ECS or similar

@WeaponOfChoice-Solirius I've added a CD workflow for tagging and pushing the images to my Azure Container Registry filevault

Copy link
Collaborator

@WeaponOfChoice-Solirius WeaponOfChoice-Solirius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Next steps would be to actually use the built image, in a hosting service. But this PR looks ready.

Just make sure with any image, test it locally, make sure you can access the app, and that it works

@lambley lambley merged commit 2e57536 into main Jul 24, 2024
6 checks passed
@lambley lambley deleted the github-actions branch July 24, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants