-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add github action for lint and test #6
Conversation
lambley
commented
Jul 19, 2024
•
edited
Loading
edited
- add workflow to run lint and test, and exit if either fail
- add sonarless-scan - only check for vulnerabilities, code smells, duplications and coverage
I'll add pushing to Azure Container registry to the CI actions |
As mentioned in our standup - please Dockerise the app, and include that in your CI workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dockerfile and build to ECR or similar
Add image build and deploy to ECS or similar
@WeaponOfChoice-Solirius I've added a CD workflow for tagging and pushing the images to my Azure Container Registry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Next steps would be to actually use the built image, in a hosting service. But this PR looks ready.
Just make sure with any image, test it locally, make sure you can access the app, and that it works