Promote DocBlock to native types #128
Conversation
| @@ -73,7 +71,7 @@ public function canCreate(ContainerInterface $container, $requestedName) | |||
| * | |||
| * @return array | |||
There was a problem hiding this comment.
PHP Code Sniffer keeps @return array notation to let be more specific if the developer is willing to be so
|
@Slamdunk What do you think? |
|
Even though it seems big, not even e single LOC of https://docs.laminas.dev/laminas-form/ needs to be changed (AFAICT). The only and most common extension point is the Users so advanced to write their own $ php-cs-fixer fix --verbose --rules=phpdoc_to_param_type,phpdoc_to_return_type --allow-risky=yes |
|
@Slamdunk
That would be great! 👍 |
|
I don't see an UPGRADE file or page, is there a standard to write and publish it in |
|
I created a |
|
The documentation is the right place for this and a new page is on the way with #123 |
…urnType,MissingParamType Signed-off-by: Filippo Tessarotto <[email protected]>
Signed-off-by: Filippo Tessarotto <[email protected]>
Signed-off-by: Filippo Tessarotto <[email protected]>
Signed-off-by: Filippo Tessarotto <[email protected]>
…ky=yes Signed-off-by: Filippo Tessarotto <[email protected]>
Signed-off-by: Filippo Tessarotto <[email protected]>
Signed-off-by: Filippo Tessarotto <[email protected]>
… external library Signed-off-by: Filippo Tessarotto <[email protected]>
Signed-off-by: Filippo Tessarotto <[email protected]>
| ## Native types | ||
|
|
||
| laminas-form v3 promoted `@param` and `@return` annotations of non-mixed types to | ||
| the corresponding function signatures. This change should affect only highly customized | ||
| element, fieldset or form classes. | ||
| If you need to automate native types promotion, [PHP-CS-Fixer](https://github.com/FriendsOfPHP/PHP-CS-Fixer) | ||
| can help you with this command: | ||
|
|
||
| ```console | ||
| $ php-cs-fixer fix --rules=phpdoc_to_param_type,phpdoc_to_return_type --allow-risky=yes path/to/my/custom/forms/ | ||
| ``` | ||
|
|
|
@driehle @froschdesign I'd like to release I've already tested |
|
@driehle Help is welcome at any time! 😃 |
No description provided.