Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Regression" in [email protected] #118

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jan 12, 2025

Q A
QA yes

Description

laminas-filter 2.40 changes the FilterChain callable from a legacy callable array to first class callable syntax:

https://github.com/laminas/laminas-filter/pull/190/files#r1912528133

The test case here is wrong to test the implementation detail of the callable, instead it should test behaviour of the expected chain item.

Also baselines deprecations in laminas-filter 2.40

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Input Filter 2.40 changes the FilterChain callable from a legacy callable array to first class callable syntax:

https://github.com/laminas/laminas-filter/pull/190/files#r1912528133

The test case here is wrong to test the implementation detail of the callable, instead it should test behaviour of the expected chain item.

Signed-off-by: George Steel <[email protected]>
@gsteel gsteel added the QA Quality assurance tasks such as static analysis improvements label Jan 12, 2025
@gsteel gsteel added this to the 2.32.0 milestone Jan 12, 2025
Signed-off-by: George Steel <[email protected]>
@gsteel gsteel self-assigned this Jan 13, 2025
@gsteel gsteel merged commit bd30348 into laminas:2.32.x Jan 13, 2025
14 checks passed
@gsteel gsteel deleted the v2/fix-tests branch January 13, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Quality assurance tasks such as static analysis improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants