Fix invalid call to SerializableLimitIterator's constructor #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arhimede <[email protected]>
Ocramius
requested changes
Mar 29, 2023
src/SerializableLimitIterator.php
Outdated
Comment on lines
82
to
84
| $this->__construct($data['it'], $data['offset'], $data['count']); | ||
| $this->seek($data['pos'] + $data['offset']); | ||
| $this->offset = (int) $data['offset']; | ||
| $this->count = (int) $data['count']; | ||
| parent::__construct($data['it'], $this->offset, $this->count); |
There was a problem hiding this comment.
Any way we can test how it was broken before? 🤔
There was a problem hiding this comment.
Besides the constructor and Psalm: the call of seek has been removed without any effect, which indicates that tests are missing.
There was a problem hiding this comment.
Oops, missing seek issue is fixed now
Signed-off-by: arhimede <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes an error identified by Psalm during the validation of
src/SerializableLimitIterator.php:The error is caused by a direct call to
SerializableLimitIterator's constructor from its__unserializemethod.