Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for PHP 8.4 #255

Merged
merged 12 commits into from
Nov 21, 2024
Merged

Add Support for PHP 8.4 #255

merged 12 commits into from
Nov 21, 2024

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Nov 21, 2024

No description provided.

@fezfez fezfez mentioned this pull request Nov 21, 2024
Closed
gsteel
gsteel requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fezfez - If you can make the suggested changes to the docs, this is good to go. I have a feeling that changing the headings to level 2 will mess up the styling 👍

docs/book/v2/helpers/escape.md Outdated Show resolved Hide resolved
docs/book/v2/helpers/escape.md Outdated Show resolved Hide resolved
docs/book/v2/helpers/head-meta.md Outdated Show resolved Hide resolved
docs/book/v2/helpers/head-meta.md Outdated Show resolved Hide resolved
docs/book/v2/helpers/head-script.md Outdated Show resolved Hide resolved
docs/book/v2/helpers/inline-script.md Outdated Show resolved Hide resolved
docs/book/v2/helpers/intro.md Outdated
@@ -12,7 +12,7 @@ used to retrieve that instance. `Laminas\View\Renderer\PhpRenderer` composes a
method overloading capabilities that allow proxying method calls to helpers.

<!-- markdownlint-disable-next-line header-increment -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- markdownlint-disable-next-line header-increment -->
<!-- markdownlint-disable-next-line heading-increment -->

docs/book/v2/helpers/intro.md Outdated Show resolved Hide resolved
docs/book/v2/helpers/partial.md Outdated Show resolved Hide resolved
docs/book/v2/helpers/partial.md Outdated Show resolved Hide resolved
@gsteel gsteel added this to the 2.36.0 milestone Nov 21, 2024
@gsteel gsteel self-assigned this Nov 21, 2024
fezfez and others added 10 commits November 21, 2024 18:17
@fezfez @gsteel
Update docs/book/v2/helpers/partial.md
d2c8706 
Co-authored-by: George Steel <[email protected]>
Signed-off-by: Stéphane <[email protected]>
@fezfez @gsteel
Update docs/book/v2/helpers/escape.md
8a3b076 
Co-authored-by: George Steel <[email protected]>
Signed-off-by: Stéphane <[email protected]>
@fezfez @gsteel
Update docs/book/v2/helpers/escape.md
0466ebb 
Co-authored-by: George Steel <[email protected]>
Signed-off-by: Stéphane <[email protected]>
@fezfez @gsteel
Update docs/book/v2/helpers/head-meta.md
d03d7da 
Co-authored-by: George Steel <[email protected]>
Signed-off-by: Stéphane <[email protected]>
@fezfez @gsteel
Update docs/book/v2/helpers/head-script.md
211606e 
Co-authored-by: George Steel <[email protected]>
Signed-off-by: Stéphane <[email protected]>
@fezfez @gsteel
Update docs/book/v2/helpers/inline-script.md
7dddb36 
Co-authored-by: George Steel <[email protected]>
Signed-off-by: Stéphane <[email protected]>
@fezfez @gsteel
Update docs/book/v2/helpers/intro.md
49c900f 
Co-authored-by: George Steel <[email protected]>
Signed-off-by: Stéphane <[email protected]>
@fezfez @gsteel
Update docs/book/v2/helpers/head-script.md
f0008d4 
Co-authored-by: George Steel <[email protected]>
Signed-off-by: Stéphane <[email protected]>
@fezfez @gsteel
Update docs/book/v2/helpers/head-style.md
ee6d213 
Co-authored-by: George Steel <[email protected]>
Signed-off-by: Stéphane <[email protected]>
@fezfez @gsteel
Update docs/book/v2/helpers/head-style.md
0942306 
Co-authored-by: George Steel <[email protected]>
Signed-off-by: Stéphane <[email protected]>
gsteel
gsteel requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a few more outdated linting suppressions have been found. Not sure why they weren't found on the first run, but could you update those too please?

gsteel
gsteel approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @fezfez

@gsteel gsteel changed the title PHP 8.4 support added Add Support for PHP 8.4 Nov 21, 2024
@gsteel gsteel merged commit ddc9207 into laminas:2.36.x Nov 21, 2024
17 checks passed
@gsteel gsteel mentioned this pull request Nov 21, 2024
Closed
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsteel gsteel gsteel approved these changes

Assignees

@gsteel gsteel

Labels
Enhancement
Projects
PHP 8.4
Status: Done
Milestone
2.36.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fezfez @gsteel