🎨 Raise OrganismNotSet instead of AssertionError when organism is not set
#144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zethson <[email protected]>
|
I thought you wanted to avoid the traceback? |
|
This PR didn't aim at solving this issue yet (note that I hadn't linked the issue). I just noticed this while scrolling through the code. But yeah, I can just add this to this PR and hit 2 birds with 1 stone :) |
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Zethson
changed the title
ValueError instead of AssertionError when not passing an organismOrganismNotSet instead of AssertionError when organism is not set
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142
OrganismNotSeterror which suppresses the django traceback.