Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add field support for bionty base #146

Merged
merged 1 commit into from
Nov 6, 2024
Merged

✨ Add field support for bionty base #146

merged 1 commit into from
Nov 6, 2024

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Nov 6, 2024

Fixes https://github.com/laminlabs/lamindb/issues/2096

  • We now infer a string representation if Bionty is running in bionty-base mode aka when .public() was accessed
    This enables
bt.Gene.public().validate(df["Gene Symbol"], field=bt.Gene.symbol, organism="human")

to work which would earlier error with KeyError: 'FieldAttr(Gene.symbol)'.

@Zethson Zethson marked this pull request as ready for review November 6, 2024 13:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

🚀 Deployed on https://672b691cae6d5918d67f8a76--bionty-kyow.netlify.app

@github-actions github-actions bot temporarily deployed to pull request November 6, 2024 13:03 Inactive
@Zethson Zethson merged commit e1b76f0 into main Nov 6, 2024
4 checks passed
@Zethson Zethson deleted the fix/field_support_bt_base branch November 6, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Zethson